From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EF80D46A38 for ; Sun, 1 Oct 2023 18:35:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63E2A68CBDA; Sun, 1 Oct 2023 21:35:39 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6572E68CBD0 for ; Sun, 1 Oct 2023 21:35:32 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B5B1AE0004 for ; Sun, 1 Oct 2023 18:35:31 +0000 (UTC) Date: Sun, 1 Oct 2023 20:35:30 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20231001183530.GP3543730@pb2> References: <20231001180106.27631-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3538374523034232145==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3538374523034232145== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lzM1j1Hh4qIUNijn" Content-Disposition: inline --lzM1j1Hh4qIUNijn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 01, 2023 at 08:24:57PM +0200, Kieran Kunhya wrote: > Sent from my mobile device >=20 > On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, > wrote: >=20 > > EAGAIN causes an assertion failure when it is returned from the decoder > > > > Fixes: Assertion consumed !=3D (-(11)) failed at libavcodec/decode.c:462 > > Fixes: assertion_IOT_instruction_decode_c_462/poc > > > > Found-by: Hardik Shah of Vehere (Dawn Treaders team) > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/h2645_parse.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h > > index 787ce971ee4..128dea09efb 100644 > > --- a/libavcodec/h2645_parse.h > > +++ b/libavcodec/h2645_parse.h > > @@ -123,7 +123,7 @@ static inline int get_nalsize(int nal_length_size, > > const uint8_t *buf, > > > > if (*buf_index >=3D buf_size - nal_length_size) { > > // the end of the buffer is reached, refill it > > - return AVERROR(EAGAIN); > > + return AVERROR_INVALIDDATA; > > } > > > > for (i =3D 0; i < nal_length_size; i++) > > -- > > 2.17.1 > > >=20 > But these are not the same for an API user? What public API returns this ? (and doesnt crash) What public API documents this to be returned ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates --lzM1j1Hh4qIUNijn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZRm77wAKCRBhHseHBAsP qycPAJ9JROs8/NARD6TRCtaBPQLyhl0/8QCfX3bP8dR6QHyNUccdF+wLlfCIapA= =/7GD -----END PGP SIGNATURE----- --lzM1j1Hh4qIUNijn-- --===============3538374523034232145== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3538374523034232145==--