From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 2/3] swscale/rgb2rgb: avoid S-regs in RISC-V V uyvytoyuv422
Date: Sat, 30 Sep 2023 12:01:11 +0300
Message-ID: <20230930090112.376259-2-remi@remlab.net> (raw)
In-Reply-To: <20230930090112.376259-1-remi@remlab.net>
We can make do with callee-clobbered registers only now.
As an added bonus, this makes the code XLEN-independent.
---
libswscale/riscv/rgb2rgb.c | 2 --
libswscale/riscv/rgb2rgb_rvv.S | 10 ++--------
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/libswscale/riscv/rgb2rgb.c b/libswscale/riscv/rgb2rgb.c
index 162a4082b0..565f0b77f1 100644
--- a/libswscale/riscv/rgb2rgb.c
+++ b/libswscale/riscv/rgb2rgb.c
@@ -55,10 +55,8 @@ av_cold void rgb2rgb_init_riscv(void)
shuffle_bytes_1230 = ff_shuffle_bytes_1230_rvv;
shuffle_bytes_3012 = ff_shuffle_bytes_3012_rvv;
interleaveBytes = ff_interleave_bytes_rvv;
-#if (__riscv_xlen == 64)
uyvytoyuv422 = ff_uyvytoyuv422_rvv;
yuyvtoyuv422 = ff_yuyvtoyuv422_rvv;
-#endif
}
#endif
}
diff --git a/libswscale/riscv/rgb2rgb_rvv.S b/libswscale/riscv/rgb2rgb_rvv.S
index 3e7988ca01..3200370224 100644
--- a/libswscale/riscv/rgb2rgb_rvv.S
+++ b/libswscale/riscv/rgb2rgb_rvv.S
@@ -100,12 +100,9 @@ func ff_interleave_bytes_rvv, zve32x
ret
endfunc
-#if (__riscv_xlen == 64)
.macro yuy2_to_i422p y_shift
- addi sp, sp, -16
- sd s0, (sp)
addi a4, a4, 1
- lw s0, 16(sp)
+ lw t6, (sp)
srai a4, a4, 1 // pixel width -> chroma width
1:
mv t4, a4
@@ -131,14 +128,12 @@ endfunc
add t2, t5, t2
bnez t4, 2b
- add a3, a3, s0
+ add a3, a3, t6
add a0, a0, a6
add a1, a1, a7
add a2, a2, a7
bnez a5, 1b
- ld s0, (sp)
- addi sp, sp, 16
ret
.endm
@@ -149,4 +144,3 @@ endfunc
func ff_yuyvtoyuv422_rvv, zve32x
yuy2_to_i422p 0
endfunc
-#endif
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-30 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 9:01 [FFmpeg-devel] [PATCH 1/3] swscale/rgb2rgb: rework " Rémi Denis-Courmont
2023-09-30 9:01 ` Rémi Denis-Courmont [this message]
2023-09-30 9:01 ` [FFmpeg-devel] [PATCH 3/3] swscale/rgb2rgb: unroll " Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930090112.376259-2-remi@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git