Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: Re-use crypto URLContext
Date: Fri, 29 Sep 2023 18:25:32 +0200
Message-ID: <20230929162532.GD3543730@pb2> (raw)
In-Reply-To: <f821bbab-294a-4923-8880-88a40532f692@scheurenbrand.me>


[-- Attachment #1.1: Type: text/plain, Size: 1739 bytes --]

On Fri, Sep 29, 2023 at 05:10:18PM +0200, Luis Scheurenbrand via ffmpeg-devel wrote:
> Reset crypto state and keep nested http context alive.
> Previously, an unencrypted file, followed by an encrypted file would
> result in a corrupted stream, as the stream would not be closed and
> an encrypted file would be forwarded to the demuxer.
> 
> fixes: https://trac.ffmpeg.org/ticket/10599
> fixes: https://trac.ffmpeg.org/ticket/8490
> Signed-off-by: Luis Scheurenbrand <luis@scheurenbrand.me>
> ---
>  libavformat/crypto.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
>  libavformat/crypto.h | 38 ++++++++++++++++++++++++++++++
>  libavformat/hls.c    | 32 ++++++++++++++++++++++----
>  3 files changed, 120 insertions(+), 5 deletions(-)
>  create mode 100644 libavformat/crypto.h
> 
> diff --git a/libavformat/crypto.c b/libavformat/crypto.c
> index 75b00020bc..543300c7c0 100644
> --- a/libavformat/crypto.c
> +++ b/libavformat/crypto.c
> @@ -20,8 +20,10 @@
>   */
>   #include "libavutil/aes.h"
> +#include "libavutil/avassert.h"
>  #include "libavutil/avstring.h"
>  #include "libavutil/opt.h"
> +#include "crypto.h"
>  #include "url.h"
>   // encourage reads of 4096 bytes - 1 block is always retained.
> @@ -105,6 +107,59 @@ static int set_aes_arg(URLContext *h, uint8_t **buf,
> int *buf_len,
>      return 0;

this patch is corrupted with newlines, check the word/line wraping settings
of your mail setup

Applying: avformat/hls: Re-use crypto URLContext
error: corrupt patch at line 21
error: could not build fake ancestor

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-09-29 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 15:10 Luis Scheurenbrand via ffmpeg-devel
2023-09-29 16:25 ` Michael Niedermayer [this message]
2023-09-29 16:50 Luis Scheurenbrand via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230929162532.GD3543730@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git