From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F34B47967 for ; Thu, 28 Sep 2023 10:07:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A5F3E68CB32; Thu, 28 Sep 2023 13:07:52 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 542D368CA0C for ; Thu, 28 Sep 2023 13:07:46 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A4A80C000A for ; Thu, 28 Sep 2023 10:07:45 +0000 (UTC) Date: Thu, 28 Sep 2023 12:07:44 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230928100744.GW3543730@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] GBRAP14 support for MagicYUV X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2355948052893207611==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2355948052893207611== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6B5oiwbC31sfIr4n" Content-Disposition: inline --6B5oiwbC31sfIr4n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 27, 2023 at 07:24:50PM +0200, Paul B Mahol wrote: > Attached. > pixdesc.c | 28 ++++++++++++++++++++++++++++ > pixfmt.h | 4 ++++ > 2 files changed, 32 insertions(+) > dc323faf13db2ffbefdd8ce2c25ba3a97633e0eb 0001-avutil-add-GBRAP14-format-= support.patch > From 3e58da932f88e6781eb772d883efa6f0997de936 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 27 Sep 2023 16:06:02 +0200 > Subject: [PATCH 1/4] avutil: add GBRAP14 format support >=20 > Signed-off-by: Paul B Mahol > --- > libavutil/pixdesc.c | 28 ++++++++++++++++++++++++++++ > libavutil/pixfmt.h | 4 ++++ > 2 files changed, 32 insertions(+) >=20 > diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c > index e1e0dd2a9e..6ded9467b0 100644 > --- a/libavutil/pixdesc.c > +++ b/libavutil/pixdesc.c > @@ -2223,6 +2223,34 @@ static const AVPixFmtDescriptor av_pix_fmt_descrip= tors[AV_PIX_FMT_NB] =3D { > }, > .flags =3D AV_PIX_FMT_FLAG_PLANAR | AV_PIX_FMT_FLAG_BE, > }, > + [AV_PIX_FMT_GBRAP14LE] =3D { > + .name =3D "gbrap14le", > + .nb_components =3D 4, > + .log2_chroma_w =3D 0, > + .log2_chroma_h =3D 0, > + .comp =3D { > + { 2, 2, 0, 0, 14 }, /* R */ > + { 0, 2, 0, 0, 14 }, /* G */ > + { 1, 2, 0, 0, 14 }, /* B */ > + { 3, 2, 0, 0, 14 }, /* A */ > + }, > + .flags =3D AV_PIX_FMT_FLAG_PLANAR | AV_PIX_FMT_FLAG_RGB | > + AV_PIX_FMT_FLAG_ALPHA, > + }, > + [AV_PIX_FMT_GBRAP14BE] =3D { > + .name =3D "gbrap14be", > + .nb_components =3D 4, > + .log2_chroma_w =3D 0, > + .log2_chroma_h =3D 0, > + .comp =3D { > + { 2, 2, 0, 0, 14 }, /* R */ > + { 0, 2, 0, 0, 14 }, /* G */ > + { 1, 2, 0, 0, 14 }, /* B */ > + { 3, 2, 0, 0, 14 }, /* A */ > + }, > + .flags =3D AV_PIX_FMT_FLAG_BE | AV_PIX_FMT_FLAG_PLANAR | > + AV_PIX_FMT_FLAG_RGB | AV_PIX_FMT_FLAG_ALPHA, > + }, > [AV_PIX_FMT_GBRAP12LE] =3D { > .name =3D "gbrap12le", > .nb_components =3D 4, > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index 63e07ba64f..a26c72d56b 100644 > --- a/libavutil/pixfmt.h > +++ b/libavutil/pixfmt.h > @@ -426,6 +426,9 @@ enum AVPixelFormat { > AV_PIX_FMT_P412BE, ///< interleaved chroma YUV 4:4:4, 36bpp, da= ta in the high bits, big-endian > AV_PIX_FMT_P412LE, ///< interleaved chroma YUV 4:4:4, 36bpp, da= ta in the high bits, little-endian > =20 > + AV_PIX_FMT_GBRAP14BE, ///< planar GBR 4:4:4:4 56bpp, big-endian > + AV_PIX_FMT_GBRAP14LE, ///< planar GBR 4:4:4:4 56bpp, little-endian > + > AV_PIX_FMT_NB ///< number of pixel formats, DO NOT USE THIS = if you want to link with shared libav* because the number of formats might = differ between versions > }; > =20 > @@ -484,6 +487,7 @@ enum AVPixelFormat { > #define AV_PIX_FMT_GBRP16 AV_PIX_FMT_NE(GBRP16BE, GBRP16LE) > #define AV_PIX_FMT_GBRAP10 AV_PIX_FMT_NE(GBRAP10BE, GBRAP10LE) > #define AV_PIX_FMT_GBRAP12 AV_PIX_FMT_NE(GBRAP12BE, GBRAP12LE) > +#define AV_PIX_FMT_GBRAP14 AV_PIX_FMT_NE(GBRAP14BE, GBRAP14LE) > #define AV_PIX_FMT_GBRAP16 AV_PIX_FMT_NE(GBRAP16BE, GBRAP16LE) > =20 > #define AV_PIX_FMT_BAYER_BGGR16 AV_PIX_FMT_NE(BAYER_BGGR16BE, BAYER_B= GGR16LE) > --=20 > 2.42.0 >=20 > libavformat/nut.c | 2 ++ > libswscale/input.c | 7 +++++++ > libswscale/output.c | 2 ++ > libswscale/swscale_unscaled.c | 3 +++ > libswscale/utils.c | 6 ++++++ > tests/ref/fate/filter-pixdesc-gbrap14be | 1 + > tests/ref/fate/filter-pixdesc-gbrap14le | 1 + > tests/ref/fate/filter-pixfmts-copy | 2 ++ > tests/ref/fate/filter-pixfmts-crop | 2 ++ > tests/ref/fate/filter-pixfmts-field | 2 ++ > tests/ref/fate/filter-pixfmts-fieldorder | 2 ++ > tests/ref/fate/filter-pixfmts-hflip | 2 ++ > tests/ref/fate/filter-pixfmts-il | 2 ++ > tests/ref/fate/filter-pixfmts-null | 2 ++ > tests/ref/fate/filter-pixfmts-pad | 1 + > tests/ref/fate/filter-pixfmts-scale | 2 ++ > tests/ref/fate/filter-pixfmts-transpose | 2 ++ > tests/ref/fate/filter-pixfmts-vflip | 2 ++ > 18 files changed, 43 insertions(+) > 025cfa7df85fab9943d3049f729c25db5934eb3f 0002-swscale-add-GBRAP14-format= -support.patch > From 517fc54c52cfdcdbc6920ede04b215ed27429b00 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 27 Sep 2023 16:13:16 +0200 > Subject: [PATCH 2/4] swscale: add GBRAP14 format support LGTM assuming you vissually confirmed output look correct fate tests also pass on x86 32/64 mingw32/64 (arm/mips still running, if you hear nothing more then they passed too) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle --6B5oiwbC31sfIr4n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZRVQbAAKCRBhHseHBAsP q2DBAJsEgT1UYptpSQusLSKz4rG6mOXCeQCeMq+uSUjWwSyLQjj/COEz0fLFFvQ= =ZCxI -----END PGP SIGNATURE----- --6B5oiwbC31sfIr4n-- --===============2355948052893207611== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2355948052893207611==--