From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] Revert "lavu/timer: remove gratuitous volatile"
Date: Wed, 27 Sep 2023 19:25:29 +0300
Message-ID: <20230927162529.74679-1-remi@remlab.net> (raw)
It does not make much sense to me, but GCC somehow optimises the
inline assembler way even when the output are very obviously used.
This reverts commit 09731fbfc3a914ec4f6ffad60aa9062db6a8f6aa.
---
libavutil/riscv/timer.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavutil/riscv/timer.h b/libavutil/riscv/timer.h
index df1a730b5e..174b469cbe 100644
--- a/libavutil/riscv/timer.h
+++ b/libavutil/riscv/timer.h
@@ -29,13 +29,13 @@ static inline uint64_t ff_read_time(void)
#if (__riscv_xlen >= 64)
uintptr_t cycles;
- __asm__ ("rdtime %0" : "=r" (cycles));
+ __asm__ volatile ("rdtime %0" : "=r" (cycles));
#else
uint64_t cycles;
uint32_t hi, lo, check;
- __asm__ (
+ __asm__ volatile (
"1: rdtimeh %0\n"
" rdtime %1\n"
" rdtimeh %2\n"
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-09-27 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 16:25 Rémi Denis-Courmont [this message]
2023-09-27 17:03 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927162529.74679-1-remi@remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git