Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 2/5] avutil/csp: re-use av_abs_q
Date: Wed, 27 Sep 2023 12:03:53 +0200
Message-ID: <20230927100630.50510-3-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20230927100630.50510-1-ffmpeg@haasn.xyz>

From: Niklas Haas <git@haasn.dev>

---
 libavutil/csp.c | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/libavutil/csp.c b/libavutil/csp.c
index 7ef822c60bc..6522225a8d6 100644
--- a/libavutil/csp.c
+++ b/libavutil/csp.c
@@ -100,13 +100,6 @@ const AVColorPrimariesDesc *av_csp_primaries_desc_from_id(enum AVColorPrimaries
     return p;
 }
 
-static av_always_inline AVRational abs_sub_q(AVRational r1, AVRational r2)
-{
-    AVRational diff = av_sub_q(r1, r2);
-    /* denominator assumed to be positive */
-    return av_make_q(abs(diff.num), diff.den);
-}
-
 enum AVColorPrimaries av_csp_primaries_id_from_desc(const AVColorPrimariesDesc *prm)
 {
     AVRational delta;
@@ -116,14 +109,14 @@ enum AVColorPrimaries av_csp_primaries_id_from_desc(const AVColorPrimariesDesc *
         if (!ref->prim.r.x.num)
             continue;
 
-        delta = abs_sub_q(prm->prim.r.x, ref->prim.r.x);
-        delta = av_add_q(delta, abs_sub_q(prm->prim.r.y, ref->prim.r.y));
-        delta = av_add_q(delta, abs_sub_q(prm->prim.g.x, ref->prim.g.x));
-        delta = av_add_q(delta, abs_sub_q(prm->prim.g.y, ref->prim.g.y));
-        delta = av_add_q(delta, abs_sub_q(prm->prim.b.x, ref->prim.b.x));
-        delta = av_add_q(delta, abs_sub_q(prm->prim.b.y, ref->prim.b.y));
-        delta = av_add_q(delta, abs_sub_q(prm->wp.x, ref->wp.x));
-        delta = av_add_q(delta, abs_sub_q(prm->wp.y, ref->wp.y));
+        delta = av_abs_q(av_sub_q(prm->prim.r.x, ref->prim.r.x));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->prim.r.y, ref->prim.r.y)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->prim.g.x, ref->prim.g.x)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->prim.g.y, ref->prim.g.y)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->prim.b.x, ref->prim.b.x)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->prim.b.y, ref->prim.b.y)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->wp.x, ref->wp.x)));
+        delta = av_add_q(delta, av_abs_q(av_sub_q(prm->wp.y, ref->wp.y)));
 
         if (av_cmp_q(delta, av_make_q(1, 1000)) < 0)
             return p;
-- 
2.42.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-09-27 10:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 10:03 [FFmpeg-devel] [PATCH 0/5] work around broken (apple) ICCv4 profiles Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 1/5] avutil/rational: add av_abs_q Niklas Haas
2023-09-27 10:14   ` Anton Khirnov
2023-09-27 10:22   ` Andreas Rheinhardt
2023-09-27 10:03 ` Niklas Haas [this message]
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 3/5] avcodec/fflcms2: add ff_icc_profile_sanitize Niklas Haas
2023-09-27 10:20   ` Andreas Rheinhardt
2023-09-27 10:26     ` Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 4/5] avfilter/vf_iccdetect: use ff_icc_profile_sanitize Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 5/5] avcodec/decode: " Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927100630.50510-3-ffmpeg@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=git@haasn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git