From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D316C46FCF for ; Sun, 24 Sep 2023 18:48:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFB0068C94E; Sun, 24 Sep 2023 21:48:29 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6438D68C87F for ; Sun, 24 Sep 2023 21:48:23 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id B6A21C0002 for ; Sun, 24 Sep 2023 18:48:22 +0000 (UTC) Date: Sun, 24 Sep 2023 20:48:21 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230924184821.GK3543730@pb2> References: <20230923210210.3830-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libswresample/swresample: avoid s16p internal transfer format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8462135203087793937==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8462135203087793937== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5dNcufZ4prhark0F" Content-Disposition: inline --5dNcufZ4prhark0F Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 23, 2023 at 11:32:28PM +0200, Paul B Mahol wrote: > On Sat, Sep 23, 2023 at 11:02=E2=80=AFPM Michael Niedermayer > wrote: >=20 > > From: Paul B Mahol > > > > Instead use float one by default for sample rate conversions. > > The s16p internal transfer format produces visible and hearable > > quantization artifacts. > > > > Signed-off-by: Paul B Mahol > > > > for S8 we continue to use S16 as it should have enough precision > > Fate is adjusted so bitexactness is maintained between mips/arm/x86 > > if more tests became bit-inexact on some platform, the same change > > can be done to them > > > > The use of higher precision and float intermediates inevitably > > leads to more differences between platforms. > > >=20 > Could add S64 precision path, but would be slower than float, probably. > LGTM. will apply later without 2 lines (bugs noticed on rerunning with distclean) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --5dNcufZ4prhark0F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZRCEcgAKCRBhHseHBAsP qwfpAJ9tD7YodEBVDLFlgf7RfQsl52h0AgCfbIkZoxl7K8GSphuZuCL3QzDphXk= =upF5 -----END PGP SIGNATURE----- --5dNcufZ4prhark0F-- --===============8462135203087793937== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8462135203087793937==--