Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Chen Yufei <cyfdecyf@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Chen Yufei <cyfdecyf@gmail.com>
Subject: [FFmpeg-devel] [PATCH 0/2] avfilter/vf_vpp_qsv: apply 3D LUT from file
Date: Sat, 23 Sep 2023 23:36:08 +0800
Message-ID: <20230923154125.31376-1-cyfdecyf@gmail.com> (raw)

First time modifing FFmpeg code and sending patch, please bear with me for
mistakes.

Following patches add support for applying 3D LUT from file using oneVPL VPP.

Limitation:
The new feature is only available when `CONFIG_VAAPI` is enabled, because of
my limited test environemnt and little experience with video processing.

1st patch moves some 3D LUT parse function from `vf_lut3d.c` to `lut3d.c` to
expose them for use in `vf_vpp_qsv.c`. I try to move only code that deals with
3D LUT table.

2nd patch applies 3D LUT from file in `vf_vpp_qsv.c`. I followed oneVPL's
document and sample code, but there are still things that are not clear to me.
The LUT value type used in VPP is `mfxU16` instead of float, I choose to
multiply float value with 65535 to convert to `mfxU16` and the result seems correct.

Test is done on an Arch Linux system (kernel 6.5.3) with Intel Arc A380 on a
Thunderbolt 3 GPU dock. I compared transcoding output with `vf_lut3d` and don't
see noticeable difference with my eyes.

`make fate` passes without error.

Chen Yufei (2):
  avfilter/vf_lut3d: expose 3D LUT file parse function.
  avfilter/vf_vpp_qsv: apply 3D LUT from file.

 libavfilter/Makefile     |   8 +-
 libavfilter/lut3d.c      | 669 +++++++++++++++++++++++++++++++++++++++
 libavfilter/lut3d.h      |  13 +
 libavfilter/vf_lut3d.c   | 590 +---------------------------------
 libavfilter/vf_vpp_qsv.c | 242 +++++++++++++-
 5 files changed, 926 insertions(+), 596 deletions(-)
 create mode 100644 libavfilter/lut3d.c

-- 
2.42.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-09-23 15:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 15:36 Chen Yufei [this message]
2023-09-23 15:36 ` [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: expose 3D LUT file parse function Chen Yufei
2023-10-16  7:51   ` Xiang, Haihao
2023-10-23  1:16     ` Chen Yufei
2023-09-23 15:36 ` [FFmpeg-devel] [PATCH 2/2] avfilter/vf_vpp_qsv: apply 3D LUT from file Chen Yufei
2023-10-16  8:05   ` Xiang, Haihao
2023-10-23  1:27     ` Chen Yufei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230923154125.31376-1-cyfdecyf@gmail.com \
    --to=cyfdecyf@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git