From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 11B5247801 for ; Fri, 22 Sep 2023 21:52:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B2A468C8D1; Sat, 23 Sep 2023 00:52:23 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C3BAA68C81F for ; Sat, 23 Sep 2023 00:52:16 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 317931C0005 for ; Fri, 22 Sep 2023 21:52:15 +0000 (UTC) Date: Fri, 22 Sep 2023 23:52:15 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230922215215.GA3543730@pb2> References: <20230726235916.30058-1-michael@niedermayer.cc> <20230922192204.GC8640@pb2> <20230922212616.GH8640@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/rtv1: Check if the minimal size is available in decode_rtv1() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6552333501853013293==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6552333501853013293== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 22, 2023 at 11:30:37PM +0200, Paul B Mahol wrote: > On 9/22/23, Michael Niedermayer wrote: > > On Fri, Sep 22, 2023 at 09:32:47PM +0200, Paul B Mahol wrote: > >> On 9/22/23, Michael Niedermayer wrote: > >> > On Thu, Jul 27, 2023 at 01:59:13AM +0200, Michael Niedermayer wrote: > >> >> Signed-off-by: Michael Niedermayer > >> >> --- > >> >> libavcodec/rtv1.c | 6 +++++- > >> >> 1 file changed, 5 insertions(+), 1 deletion(-) > >> > > >> > will apply 1-3 of this patchset > >> > >> Are you sure this does not break decoding? > > > > Well, its a loop over 4x4 blocks, a 16bit "skip" run so the minimum > > check looks correct. > > There are 2 end of bitstream checks for early exit but they look like > > error handling not some normal exit as they leave the frame uninitializ= ed > > >=20 > FFmpeg default initialization code for AVFrame's buffers does it > twice, so they are always zeroed or previous values of previous > buffers in pool. its rare that correct frame decoding depends on internal AVFrame buffer ordering >=20 > > Do you have some files so i can double check this is not breaking anyth= ing >=20 > Search trac tickets. thanks, found a zip with 2 video files ill check it [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "I am not trying to be anyone's saviour, I'm trying to think about the future and not be sad" - Elon Musk --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZQ4MiwAKCRBhHseHBAsP qxk5AJ9vbLky+EeUgSai+GbNWuFHYGtumACgg8A5ngdrXjGoFDdSVawRV/p1ky8= =LDhK -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- --===============6552333501853013293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6552333501853013293==--