Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option
@ 2023-09-21  9:06 Peter Ross
  2023-09-22 17:06 ` Michael Niedermayer
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Ross @ 2023-09-21  9:06 UTC (permalink / raw)
  To: ffmpeg-devel


[-- Attachment #1.1: Type: text/plain, Size: 2370 bytes --]

Signed-off-by: Peter Ross <pross@xvid.org>
---

For use with uhd device with run-time selectable antenna jack.

 libavdevice/sdrindev.c | 3 +++
 libavformat/sdr.h      | 1 +
 libavformat/sdrdemux.c | 1 +
 3 files changed, 5 insertions(+)

diff --git a/libavdevice/sdrindev.c b/libavdevice/sdrindev.c
index 8766fc2f34..337bc40c76 100644
--- a/libavdevice/sdrindev.c
+++ b/libavdevice/sdrindev.c
@@ -234,6 +234,9 @@ static int sdrindev_initial_hw_setup(AVFormatContext *s)
     names = SoapySDRDevice_listAntennas(soapy, SOAPY_SDR_RX, 0, &length);
     print_and_free_list(s, names, length, "Antennas");
 
+    if (sdr->sdr_ant)
+        SoapySDRDevice_setAntenna(soapy, SOAPY_SDR_RX, 0, sdr->sdr_ant);
+
     //Go over all tunable elements
     names = SoapySDRDevice_listFrequencies(soapy, SOAPY_SDR_RX, 0, &length);
     print_and_free_list(s, names, length, "Tunables");
diff --git a/libavformat/sdr.h b/libavformat/sdr.h
index 1bf8fbef79..9cbb451418 100644
--- a/libavformat/sdr.h
+++ b/libavformat/sdr.h
@@ -153,6 +153,7 @@ typedef struct SDRContext {
     int64_t max_freq;
     int64_t min_center_freq;
     int64_t max_center_freq;
+    char *sdr_ant;
     int sdr_sample_rate;
     float min_gain;
     float max_gain;
diff --git a/libavformat/sdrdemux.c b/libavformat/sdrdemux.c
index 84dd90af80..882ae96751 100644
--- a/libavformat/sdrdemux.c
+++ b/libavformat/sdrdemux.c
@@ -2335,6 +2335,7 @@ const AVOption avpriv_sdr_options[] = {
     { "rtlsdr_fixes" , "workaround rtlsdr issues", OFFSET(rtlsdr_fixes), AV_OPT_TYPE_INT , {.i64 = -1}, -1, 1, DEC},
     { "sdrplay_fixes" , "workaround sdrplay issues", OFFSET(sdrplay_fixes), AV_OPT_TYPE_INT , {.i64 = -1}, -1, 1, DEC},
     { "dc_fix" , "Apply DC correction", OFFSET(dc_fix), AV_OPT_TYPE_INT , {.i64 = -1}, -1, 1, DEC},
+    { "sdr_ant", "sdr antenna", OFFSET(sdr_ant), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, DEC},
     { "sdr_sr"  , "sdr sample rate"  , OFFSET(sdr_sample_rate ), AV_OPT_TYPE_INT , {.i64 = 0}, 0, INT_MAX, DEC},
     { "sdr_freq", "sdr frequency"    , OFFSET(user_wanted_freq), AV_OPT_TYPE_INT64 , {.i64 = 9000000}, 0, INT64_MAX, DEC},
     { "gain" , "sdr overall gain",  OFFSET(sdr_gain),  AV_OPT_TYPE_INT , {.i64 =  GAIN_SDR_AGC}, -3, INT_MAX, DEC, "gain"},
-- 
2.40.1

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option
  2023-09-21  9:06 [FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option Peter Ross
@ 2023-09-22 17:06 ` Michael Niedermayer
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Niedermayer @ 2023-09-22 17:06 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]

On Thu, Sep 21, 2023 at 07:06:28PM +1000, Peter Ross wrote:
> Signed-off-by: Peter Ross <pross@xvid.org>
> ---
> 
> For use with uhd device with run-time selectable antenna jack.
> 
>  libavdevice/sdrindev.c | 3 +++
>  libavformat/sdr.h      | 1 +
>  libavformat/sdrdemux.c | 1 +
>  3 files changed, 5 insertions(+)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-22 17:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21  9:06 [FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option Peter Ross
2023-09-22 17:06 ` Michael Niedermayer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git