From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1486E476FF for ; Wed, 20 Sep 2023 12:18:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DDF368BFEC; Wed, 20 Sep 2023 15:18:26 +0300 (EEST) Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73E0E68C809 for ; Wed, 20 Sep 2023 15:18:19 +0300 (EEST) Received: from nick.intra.ispras.ru (unknown [10.10.34.56]) by mail.ispras.ru (Postfix) with ESMTPSA id AFC61407673D; Wed, 20 Sep 2023 12:18:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru AFC61407673D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1695212298; bh=MnWCrdt9CNmYttwAK1obiqm0PnDPkEA/F8R7vj9vWVY=; h=From:To:Cc:Subject:Date:From; b=aQ+gV7JMZpqFYexM7KxnUYE8J5TMpP/4cxl4ZjQzk1z0AtA7xoA+44NmRyp+eCytr K8OMP9S5ZKjQaKlAFr4uQidhKZTXCCZYV1tmP8mrz0OcGZNeb+YrLJssjnzIB3iZzN BqH7Fu+khk3eqsdh3OUy7k87/RFd8JDI9MXvTsBg= From: mezhuevtp@ispras.ru To: ffmpeg-devel@ffmpeg.org Date: Wed, 20 Sep 2023 15:18:03 +0300 Message-Id: <20230920121803.3456113-1-mezhuevtp@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] Hi! We've been fuzzing `ffmpeg` with [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) security predicates and we found numeric truncation error in `svs.c:57`. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: mezhuevtp@ispras.ru, headshog Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: headshog In function `svs_read_header` on line 57 field `st->codecpar->sample_rate` has type `int`, the type of return value in `av_rescale_rnd` function is `uint64_t`, so the numeric truncation may occur here. Then value of `st->codecpar->sample_rate` is passed to `avpriv_set_pts_info` function parameter `unsgined int pts_den`. In this function `pts_den` is used only in passing its value to parameter `int64_t den` in function `av_reduce`. So we suggest to change the type of field `sample_rate` to `int64_t` and to change the type of `pts_den` to `uint64_t` in `avpriv_set_pts_info` function. The other way to solve this is to add a checker for `sample_rate` valid value. - OS: ubuntu 20.04 - commit: f225f8d7464569c7b917015c26ad30a37a5fbbe2 ``` libavformat/svs.c:57:36: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value 6321554672 (64-bit, signed) to type 'int' changed the value to 2026587376 (32-bit, signed) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavformat/svs.c:57:36 ``` --- libavcodec/codec_par.h | 2 +- libavformat/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index add90fdb1e..2bbb7ba4e7 100644 --- a/libavcodec/codec_par.h +++ b/libavcodec/codec_par.h @@ -175,7 +175,7 @@ typedef struct AVCodecParameters { /** * Audio only. The number of audio samples per second. */ - int sample_rate; + int64_t sample_rate; /** * Audio only. The number of bytes per coded audio frame, required by some * formats. diff --git a/libavformat/internal.h b/libavformat/internal.h index 901a8b51c6..6e1fce41aa 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -584,7 +584,7 @@ const struct AVCodec *ff_find_decoder(AVFormatContext *s, const AVStream *st, * @param pts_den time base denominator */ void avpriv_set_pts_info(AVStream *st, int pts_wrap_bits, - unsigned int pts_num, unsigned int pts_den); + unsigned int pts_num, uint64_t pts_den); /** * Set the timebase for each stream from the corresponding codec timebase and -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".