From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68B504767B for ; Tue, 19 Sep 2023 18:24:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1276368C8EA; Tue, 19 Sep 2023 21:24:10 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 727DB68C76A for ; Tue, 19 Sep 2023 21:24:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 72545C0004 for ; Tue, 19 Sep 2023 18:24:02 +0000 (UTC) Date: Tue, 19 Sep 2023 20:24:01 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230919182401.GD8640@pb2> References: <20230918223534.23567-1-michael@niedermayer.cc> <20230918223534.23567-5-michael@niedermayer.cc> <43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com> MIME-Version: 1.0 In-Reply-To: <43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5564033816233539108==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5564033816233539108== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BRF4e1IEQp0HoEFj" Content-Disposition: inline --BRF4e1IEQp0HoEFj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2023 at 08:30:58PM -0300, James Almer wrote: > On 9/18/2023 7:35 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/decode.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index 169ee79acd9..376e4a4d373 100644 > > --- a/libavcodec/decode.c > > +++ b/libavcodec/decode.c > > @@ -457,6 +457,7 @@ FF_ENABLE_DEPRECATION_WARNINGS > > if (ret =3D=3D AVERROR(EAGAIN)) > > av_frame_unref(frame); > > + av_assert0(consumed !=3D AVERROR(EAGAIN)); // code later will add = AVERROR(EAGAIN) to a pointer >=20 > FF_CODEC_CB_TYPE_DECODE decoders must not return EAGAIN or EOF, only actu= al > error codes. IMO that should be stated too. ok will apply with an expanded comment >=20 > > if (consumed < 0) > > ret =3D consumed; > > if (consumed >=3D 0 && avctx->codec->type =3D=3D AVMEDIA_TYPE_VID= EO) >=20 > LGTM. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact --BRF4e1IEQp0HoEFj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZQnnQQAKCRBhHseHBAsP q4iXAJsEJk3jzd1cok2cvJw8GrvlqS8vOgCfR4Fbmoj0UCY+qoj0V7ENoEfzDIM= =HDkQ -----END PGP SIGNATURE----- --BRF4e1IEQp0HoEFj-- --===============5564033816233539108== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5564033816233539108==--