Re: [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal()

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/decode: EAGAIN is not fully supported in decode_simple_internal()
Date: Tue, 19 Sep 2023 20:24:01 +0200
Message-ID: <20230919182401.GD8640@pb2> (raw)
In-Reply-To: <43a6c010-6c47-a388-7136-3d150a4941b9@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]

On Mon, Sep 18, 2023 at 08:30:58PM -0300, James Almer wrote:
> On 9/18/2023 7:35 PM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >   libavcodec/decode.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/libavcodec/decode.c b/libavcodec/decode.c
> > index 169ee79acd9..376e4a4d373 100644
> > --- a/libavcodec/decode.c
> > +++ b/libavcodec/decode.c
> > @@ -457,6 +457,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >       if (ret == AVERROR(EAGAIN))
> >           av_frame_unref(frame);
> > +    av_assert0(consumed != AVERROR(EAGAIN)); // code later will add AVERROR(EAGAIN) to a pointer
> 
> FF_CODEC_CB_TYPE_DECODE decoders must not return EAGAIN or EOF, only actual
> error codes. IMO that should be stated too.

ok will apply with an expanded comment

> 
> >       if (consumed < 0)
> >           ret = consumed;
> >       if (consumed >= 0 && avctx->codec->type == AVMEDIA_TYPE_VIDEO)
> 
> LGTM.

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".