Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support
       [not found] <20230906221930.ACB65410B57@natalya.videolan.org>
@ 2023-09-14 22:19 ` Michael Niedermayer
  2023-09-14 23:24   ` Paul B Mahol
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Niedermayer @ 2023-09-14 22:19 UTC (permalink / raw)
  To: ffmpeg-devel


[-- Attachment #1.1: Type: text/plain, Size: 3106 bytes --]

On Wed, Sep 06, 2023 at 10:19:29PM +0000, Christophe Gisquet wrote:
> ffmpeg | branch: master | Christophe Gisquet <christophe.gisquet@gmail.com> | Sun Jul  9 12:56:35 2017 +0000| [da888b790af779a7489068c25f9e7ab8ac653d41] | committer: Paul B Mahol
> 
> avcodec/utvideodec: add vlc multi support
> 
> Faster decoding, by average 50% faster overall.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=da888b790af779a7489068c25f9e7ab8ac653d41
> ---
> 
>  libavcodec/utvideo.h    |  1 +
>  libavcodec/utvideodec.c | 92 ++++++++++++++++++++++++-------------------------
>  2 files changed, 46 insertions(+), 47 deletions(-)
> 
> diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h
> index 9da9329ff3..e5160aa394 100644
> --- a/libavcodec/utvideo.h
> +++ b/libavcodec/utvideo.h
> @@ -81,6 +81,7 @@ typedef struct UtvideoContext {
>      ptrdiff_t slice_stride;
>      uint8_t *slice_bits, *slice_buffer[4];
>      int      slice_bits_size;
> +    void    *buffer;
>  
>      const uint8_t *packed_stream[4][256];
>      size_t packed_stream_size[4][256];
> diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> index 1f00c58950..ab390be0fa 100644
> --- a/libavcodec/utvideodec.c
> +++ b/libavcodec/utvideodec.c
> @@ -46,7 +46,7 @@ typedef struct HuffEntry {
>  } HuffEntry;
>  
>  static int build_huff(UtvideoContext *c, const uint8_t *src, VLC *vlc,
> -                      int *fsym, unsigned nb_elems)
> +                      VLC_MULTI *multi, int *fsym, unsigned nb_elems)
>  {

before this patch the whole application finishes within 130ms
after this patch with teh short table

255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,

this times out eventually not exiting the first call
it always got stuck in many calls to add_level()

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship: All citizens are under surveillance, all their steps and
actions recorded, for the politicians to enforce control.
Democracy: All politicians are under surveillance, all their steps and
actions recorded, for the citizens to enforce control.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support
  2023-09-14 22:19 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support Michael Niedermayer
@ 2023-09-14 23:24   ` Paul B Mahol
  2023-09-16 16:40     ` Michael Niedermayer
  0 siblings, 1 reply; 4+ messages in thread
From: Paul B Mahol @ 2023-09-14 23:24 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On Fri, Sep 15, 2023 at 12:19 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Wed, Sep 06, 2023 at 10:19:29PM +0000, Christophe Gisquet wrote:
> > ffmpeg | branch: master | Christophe Gisquet <
> christophe.gisquet@gmail.com> | Sun Jul  9 12:56:35 2017 +0000|
> [da888b790af779a7489068c25f9e7ab8ac653d41] | committer: Paul B Mahol
> >
> > avcodec/utvideodec: add vlc multi support
> >
> > Faster decoding, by average 50% faster overall.
> >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=da888b790af779a7489068c25f9e7ab8ac653d41
> > ---
> >
> >  libavcodec/utvideo.h    |  1 +
> >  libavcodec/utvideodec.c | 92
> ++++++++++++++++++++++++-------------------------
> >  2 files changed, 46 insertions(+), 47 deletions(-)
> >
> > diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h
> > index 9da9329ff3..e5160aa394 100644
> > --- a/libavcodec/utvideo.h
> > +++ b/libavcodec/utvideo.h
> > @@ -81,6 +81,7 @@ typedef struct UtvideoContext {
> >      ptrdiff_t slice_stride;
> >      uint8_t *slice_bits, *slice_buffer[4];
> >      int      slice_bits_size;
> > +    void    *buffer;
> >
> >      const uint8_t *packed_stream[4][256];
> >      size_t packed_stream_size[4][256];
> > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> > index 1f00c58950..ab390be0fa 100644
> > --- a/libavcodec/utvideodec.c
> > +++ b/libavcodec/utvideodec.c
> > @@ -46,7 +46,7 @@ typedef struct HuffEntry {
> >  } HuffEntry;
> >
> >  static int build_huff(UtvideoContext *c, const uint8_t *src, VLC *vlc,
> > -                      int *fsym, unsigned nb_elems)
> > +                      VLC_MULTI *multi, int *fsym, unsigned nb_elems)
> >  {
>
> before this patch the whole application finishes within 130ms
> after this patch with teh short table
>
>
> 255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,
>

This is of no use to me.
If you have file then provide it.


>
> this times out eventually not exiting the first call
> it always got stuck in many calls to add_level()
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Dictatorship: All citizens are under surveillance, all their steps and
> actions recorded, for the politicians to enforce control.
> Democracy: All politicians are under surveillance, all their steps and
> actions recorded, for the citizens to enforce control.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support
  2023-09-14 23:24   ` Paul B Mahol
@ 2023-09-16 16:40     ` Michael Niedermayer
  2023-09-17  8:40       ` Paul B Mahol
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Niedermayer @ 2023-09-16 16:40 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


[-- Attachment #1.1.1: Type: text/plain, Size: 3323 bytes --]

On Fri, Sep 15, 2023 at 01:24:39AM +0200, Paul B Mahol wrote:
> On Fri, Sep 15, 2023 at 12:19 AM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Wed, Sep 06, 2023 at 10:19:29PM +0000, Christophe Gisquet wrote:
> > > ffmpeg | branch: master | Christophe Gisquet <
> > christophe.gisquet@gmail.com> | Sun Jul  9 12:56:35 2017 +0000|
> > [da888b790af779a7489068c25f9e7ab8ac653d41] | committer: Paul B Mahol
> > >
> > > avcodec/utvideodec: add vlc multi support
> > >
> > > Faster decoding, by average 50% faster overall.
> > >
> > > >
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=da888b790af779a7489068c25f9e7ab8ac653d41
> > > ---
> > >
> > >  libavcodec/utvideo.h    |  1 +
> > >  libavcodec/utvideodec.c | 92
> > ++++++++++++++++++++++++-------------------------
> > >  2 files changed, 46 insertions(+), 47 deletions(-)
> > >
> > > diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h
> > > index 9da9329ff3..e5160aa394 100644
> > > --- a/libavcodec/utvideo.h
> > > +++ b/libavcodec/utvideo.h
> > > @@ -81,6 +81,7 @@ typedef struct UtvideoContext {
> > >      ptrdiff_t slice_stride;
> > >      uint8_t *slice_bits, *slice_buffer[4];
> > >      int      slice_bits_size;
> > > +    void    *buffer;
> > >
> > >      const uint8_t *packed_stream[4][256];
> > >      size_t packed_stream_size[4][256];
> > > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> > > index 1f00c58950..ab390be0fa 100644
> > > --- a/libavcodec/utvideodec.c
> > > +++ b/libavcodec/utvideodec.c
> > > @@ -46,7 +46,7 @@ typedef struct HuffEntry {
> > >  } HuffEntry;
> > >
> > >  static int build_huff(UtvideoContext *c, const uint8_t *src, VLC *vlc,
> > > -                      int *fsym, unsigned nb_elems)
> > > +                      VLC_MULTI *multi, int *fsym, unsigned nb_elems)
> > >  {
> >
> > before this patch the whole application finishes within 130ms
> > after this patch with teh short table
> >
> >
> > 255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,
> >
> 
> This is of no use to me.
> If you have file then provide it.

I dont have one but I made one for you
its attached


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin

[-- Attachment #1.1.2: ut.avi.gz --]
[-- Type: application/gzip, Size: 516 bytes --]

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support
  2023-09-16 16:40     ` Michael Niedermayer
@ 2023-09-17  8:40       ` Paul B Mahol
  0 siblings, 0 replies; 4+ messages in thread
From: Paul B Mahol @ 2023-09-17  8:40 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On Sat, Sep 16, 2023 at 6:40 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Sep 15, 2023 at 01:24:39AM +0200, Paul B Mahol wrote:
> > On Fri, Sep 15, 2023 at 12:19 AM Michael Niedermayer <
> michael@niedermayer.cc>
> > wrote:
> >
> > > On Wed, Sep 06, 2023 at 10:19:29PM +0000, Christophe Gisquet wrote:
> > > > ffmpeg | branch: master | Christophe Gisquet <
> > > christophe.gisquet@gmail.com> | Sun Jul  9 12:56:35 2017 +0000|
> > > [da888b790af779a7489068c25f9e7ab8ac653d41] | committer: Paul B Mahol
> > > >
> > > > avcodec/utvideodec: add vlc multi support
> > > >
> > > > Faster decoding, by average 50% faster overall.
> > > >
> > > > >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=da888b790af779a7489068c25f9e7ab8ac653d41
> > > > ---
> > > >
> > > >  libavcodec/utvideo.h    |  1 +
> > > >  libavcodec/utvideodec.c | 92
> > > ++++++++++++++++++++++++-------------------------
> > > >  2 files changed, 46 insertions(+), 47 deletions(-)
> > > >
> > > > diff --git a/libavcodec/utvideo.h b/libavcodec/utvideo.h
> > > > index 9da9329ff3..e5160aa394 100644
> > > > --- a/libavcodec/utvideo.h
> > > > +++ b/libavcodec/utvideo.h
> > > > @@ -81,6 +81,7 @@ typedef struct UtvideoContext {
> > > >      ptrdiff_t slice_stride;
> > > >      uint8_t *slice_bits, *slice_buffer[4];
> > > >      int      slice_bits_size;
> > > > +    void    *buffer;
> > > >
> > > >      const uint8_t *packed_stream[4][256];
> > > >      size_t packed_stream_size[4][256];
> > > > diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c
> > > > index 1f00c58950..ab390be0fa 100644
> > > > --- a/libavcodec/utvideodec.c
> > > > +++ b/libavcodec/utvideodec.c
> > > > @@ -46,7 +46,7 @@ typedef struct HuffEntry {
> > > >  } HuffEntry;
> > > >
> > > >  static int build_huff(UtvideoContext *c, const uint8_t *src, VLC
> *vlc,
> > > > -                      int *fsym, unsigned nb_elems)
> > > > +                      VLC_MULTI *multi, int *fsym, unsigned
> nb_elems)
> > > >  {
> > >
> > > before this patch the whole application finishes within 130ms
> > > after this patch with teh short table
> > >
> > >
> > >
> 255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,24,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,23,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,
> > >
> >
> > This is of no use to me.
> > If you have file then provide it.
>
> I dont have one but I made one for you
> its attached
>

See vlc patch on ML.


>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> While the State exists there can be no freedom; when there is freedom there
> will be no State. -- Vladimir Lenin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-17  8:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230906221930.ACB65410B57@natalya.videolan.org>
2023-09-14 22:19 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/utvideodec: add vlc multi support Michael Niedermayer
2023-09-14 23:24   ` Paul B Mahol
2023-09-16 16:40     ` Michael Niedermayer
2023-09-17  8:40       ` Paul B Mahol

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git