From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3649A47642 for ; Fri, 15 Sep 2023 14:38:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6598868C77C; Fri, 15 Sep 2023 17:38:15 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4122B68C5D9 for ; Fri, 15 Sep 2023 17:38:09 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E3FD4000F for ; Fri, 15 Sep 2023 14:38:08 +0000 (UTC) Date: Fri, 15 Sep 2023 16:38:07 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230915143807.GU8640@pb2> References: <20230915131147.5945-1-michael@niedermayer.cc> <20230915131147.5945-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4380079199306986026==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4380079199306986026== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V8Y3+xXnhQGsvjWT" Content-Disposition: inline --V8Y3+xXnhQGsvjWT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 15, 2023 at 03:54:19PM +0200, Paul B Mahol wrote: > On Fri, Sep 15, 2023 at 3:12=E2=80=AFPM Michael Niedermayer > wrote: >=20 > > The code should be changed to not use floats in the VLC parameters > > This patch merely fixes undefined behavior > > > > Fixes: 2.96539e+09 is outside the range of representable values of type > > 'int' > > Fixes: Assertion n>=3D0 && n<=3D32 failed at libavcodec/get_bits.h:423 > > Fixes: > > 62241/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-4525= 761925873664 > > >=20 >=20 > NAK >=20 > Breaks decoding. Please provide sample that works before and fails after this. That said, it has to be pointed out that the current code in osq is buggy in multiply ways. The use of floats for computing vlc parameters is not portable (unless theres alot of luck). thx [....] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates --V8Y3+xXnhQGsvjWT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZQRsSwAKCRBhHseHBAsP qy90AKCFB1K7mJNkUNH9djXccGRcAeIqAgCdEpA19gl2nERl/ooMrVPwgOvT60I= =rzjs -----END PGP SIGNATURE----- --V8Y3+xXnhQGsvjWT-- --===============4380079199306986026== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4380079199306986026==--