From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A08314760F for ; Thu, 14 Sep 2023 19:50:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D29868C808; Thu, 14 Sep 2023 22:50:02 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6EBC68C759 for ; Thu, 14 Sep 2023 22:49:55 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id CC20A240004 for ; Thu, 14 Sep 2023 19:49:53 +0000 (UTC) Date: Thu, 14 Sep 2023 21:49:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230914194953.GR8640@pb2> References: <20230619230424.30270-1-michael@niedermayer.cc> <20230619233640.GC1391451@pb2> MIME-Version: 1.0 In-Reply-To: <20230619233640.GC1391451@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/huffyuvdec: avoid undefined behavior with get_vlc2() failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1657660598896468278==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1657660598896468278== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zGX6P/PxmcOG18lb" Content-Disposition: inline --zGX6P/PxmcOG18lb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 20, 2023 at 01:36:40AM +0200, Michael Niedermayer wrote: > On Tue, Jun 20, 2023 at 01:05:45AM +0200, Paul B Mahol wrote: > > Shouldnt it error out instead? >=20 > yes but that would make it slower. Also i think real files (not fuzzeed f= iles) > would use vlc tables that have no "holes" that can generate invalid retur= ns > so the check might on top of being slow also be not that useful. > But i surely can add a check if thats what people prefer? no reply so ill apply the original patch, so this is fixed [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data --zGX6P/PxmcOG18lb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZQNj4QAKCRBhHseHBAsP q8YhAKCNZLCL7iYVCAu1hWB5MimxjoRsGACfQ7w4wGQ16FLzmN4AnEEf9CEL/BU= =RR1Z -----END PGP SIGNATURE----- --zGX6P/PxmcOG18lb-- --===============1657660598896468278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1657660598896468278==--