From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CB0A14746E for ; Thu, 7 Sep 2023 23:41:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C13F68C886; Fri, 8 Sep 2023 02:41:37 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 27D1168C7BC for ; Fri, 8 Sep 2023 02:41:31 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 742A9FF804 for ; Thu, 7 Sep 2023 23:41:30 +0000 (UTC) Date: Fri, 8 Sep 2023 01:41:29 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230907234129.GV8640@pb2> References: <20230907020645.37017-1-jamrial@gmail.com> <20230907175525.939-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230907175525.939-1-jamrial@gmail.com> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: export pixel format even if no hardware decoder is present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4036504596535137339==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4036504596535137339== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4HoONH8zr3Mj5MZN" Content-Disposition: inline --4HoONH8zr3Mj5MZN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 07, 2023 at 02:55:25PM -0300, James Almer wrote: > And remove the AVOID_PROBING flag, given it's the last av1 decoder to be = tested > either way. > This fixes a regression introduced in 1652f2492f88434010053289d946dab6a57= e4d58, > where even if forcing the native av1 decoder, if another decoder was pres= ent, > like libdav1d or libaom-av1, they'd be used for probing and some fate tes= ts > would have different results. >=20 > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 50 ++++++++++++++++++++------------- > tests/fate/lavf-container.mak | 8 +++--- > tests/ref/fate/av1-annexb-demux | 2 +- > tests/ref/lavf-fate/av1.mkv | 4 +-- > tests/ref/lavf-fate/av1.mp4 | 4 +-- > 5 files changed, 39 insertions(+), 29 deletions(-) breaks some fate tests like: make fate-cbs-av1-non_uniform_tiling TEST cbs-av1-non_uniform_tiling --- ./tests/ref/fate/cbs-av1-non_uniform_tiling 2023-09-07 20:08:32.2525826= 73 +0200 +++ tests/data/fate/cbs-av1-non_uniform_tiling 2023-09-08 01:40:11.10309142= 4 +0200 @@ -1 +0,0 @@ -3e204ee8a71273cf0247f48e977e64b7 Test cbs-av1-non_uniform_tiling failed. Look at tests/data/fate/cbs-av1-non= _uniform_tiling.err for details. tests/Makefile:308: recipe for target 'fate-cbs-av1-non_uniform_tiling' fai= led make: *** [fate-cbs-av1-non_uniform_tiling] Error 134 V=3D2 output: Assertion n >=3D 1 failed at libavcodec/decode.c:1274 Aborted (core dumped) threads=3D1 tests/Makefile:308: recipe for target 'fate-cbs-av1-non_uniform_tiling' fai= led make: *** [fate-cbs-av1-non_uniform_tiling] Error 134 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --4HoONH8zr3Mj5MZN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZPpfpgAKCRBhHseHBAsP q+7xAJ0ckoMj7M7ZWhkJUtqKA4kEzN8ZGgCgg1yzBIyb2PZSIgXN96qjRoX2sBA= =FkNu -----END PGP SIGNATURE----- --4HoONH8zr3Mj5MZN-- --===============4036504596535137339== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4036504596535137339==--