From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option
Date: Mon, 4 Sep 2023 21:00:39 +0200
Message-ID: <20230904190039.GK8640@pb2> (raw)
In-Reply-To: <20230610183109.24802-2-michael@niedermayer.cc>
[-- Attachment #1.1: Type: text/plain, Size: 1204 bytes --]
On Sat, Jun 10, 2023 at 08:31:09PM +0200, Michael Niedermayer wrote:
> jpeg2000 overrides the global lowres variable with a lowres field called reduction_factor
> ffmpeg -lowres X causes the reduction_factor to be set
> ffplay -lowres X causes both lowres and the reduction_factor to be set
> ossfuss sets only lowres
>
> only the ffmpeg variant works. This patch tries to make the other 2 work.
>
> Alternative we could just error out if things are inconsistent.
> More complex restructuring should be limited to the master branch
> to keep this reasonably easy to backport
>
> Fixes: out of array access
> Fixes: 59672/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/jpeg2000dec.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
if there are no objections then i plan to apply this in a few days
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Never trust a computer, one day, it may think you are the virus. -- Compn
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-04 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 18:31 [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset Michael Niedermayer
2023-06-10 18:31 ` [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option Michael Niedermayer
2023-06-24 10:53 ` Tomas Härdin
2023-06-24 17:54 ` Paul B Mahol
2023-06-24 20:46 ` Tomas Härdin
2023-06-24 20:56 ` James Almer
2023-09-04 19:00 ` Michael Niedermayer [this message]
2023-06-24 10:50 ` [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset Tomas Härdin
2023-06-24 19:51 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904190039.GK8640@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git