From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 13/17] avcodec/mpeg12dec: stop propagating AVCPBProperties side data Date: Mon, 4 Sep 2023 12:04:06 -0300 Message-ID: <20230904150411.56777-14-jamrial@gmail.com> (raw) In-Reply-To: <20230904150411.56777-1-jamrial@gmail.com> Signed-off-by: James Almer <jamrial@gmail.com> --- libavcodec/mpeg12dec.c | 10 ++-------- libavcodec/mpegvideo_parser.c | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 2290a90778..1accd07e9e 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1248,7 +1248,8 @@ static int mpeg_decode_postinit(AVCodecContext *avctx) if (ret < 0) return ret; - if (avctx->codec_id == AV_CODEC_ID_MPEG2VIDEO && s->bit_rate) { + if (avctx->codec_id == AV_CODEC_ID_MPEG2VIDEO && s->bit_rate && + (s->bit_rate != 0x3FFFF*400)) { avctx->rc_max_rate = s->bit_rate; } else if (avctx->codec_id == AV_CODEC_ID_MPEG1VIDEO && s->bit_rate && (s->bit_rate != 0x3FFFF*400 || s->vbv_delay != 0xFFFF)) { @@ -1371,7 +1372,6 @@ static void mpeg_decode_sequence_extension(Mpeg1Context *s1) MpegEncContext *s = &s1->mpeg_enc_ctx; int horiz_size_ext, vert_size_ext; int bit_rate_ext; - AVCPBProperties *cpb_props; skip_bits(&s->gb, 1); /* profile and level esc*/ s->avctx->profile = get_bits(&s->gb, 3); @@ -1403,12 +1403,6 @@ static void mpeg_decode_sequence_extension(Mpeg1Context *s1) ff_dlog(s->avctx, "sequence extension\n"); s->codec_id = s->avctx->codec_id = AV_CODEC_ID_MPEG2VIDEO; - if (cpb_props = ff_add_cpb_side_data(s->avctx)) { - cpb_props->buffer_size = s->avctx->rc_buffer_size; - if (s->bit_rate != 0x3FFFF*400) - cpb_props->max_bitrate = s->bit_rate; - } - if (s->avctx->debug & FF_DEBUG_PICT_INFO) av_log(s->avctx, AV_LOG_DEBUG, "profile: %d, level: %d ps: %d cf:%d vbv buffer: %d, bitrate:%"PRId64"\n", diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index 1204789c67..d0b22634bb 100644 --- a/libavcodec/mpegvideo_parser.c +++ b/libavcodec/mpegvideo_parser.c @@ -233,7 +233,7 @@ FF_ENABLE_DEPRECATION_WARNINGS if (set_dim_ret < 0) av_log(avctx, AV_LOG_ERROR, "Failed to set dimensions\n"); - if (avctx->codec_id == AV_CODEC_ID_MPEG2VIDEO && bit_rate) { + if (avctx->codec_id == AV_CODEC_ID_MPEG2VIDEO && bit_rate && bit_rate != 0x3FFFF) { avctx->rc_max_rate = 400LL*bit_rate; } if (bit_rate && -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-04 15:06 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-04 15:03 [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters " James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: add side data to AVCodecContext James Almer 2023-09-04 22:08 ` James Almer 2023-09-05 11:07 ` Anton Khirnov 2023-09-05 11:26 ` James Almer 2023-09-05 11:37 ` Anton Khirnov 2023-09-05 11:52 ` James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 02/17] avcodec/codec_par: add side data to AVCodecParameters James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 03/17] avformat/avformat: use the side data from AVStream.codecpar James Almer 2023-09-04 22:09 ` James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 04/17] fftools/ffmpeg: stop using AVStream.side_data James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 05/17] fftools/ffplay: " James Almer 2023-09-04 15:03 ` [FFmpeg-devel] [PATCH 06/17] fftools/ffprobe: " James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 07/17] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 08/17] avcodec/decode: check for global side data " James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 09/17] fftools/ffmpeg: stop injecting stream side data in packets James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 10/17] fftools/ffplay: " James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 11/17] Revert "avcodec/mpeg12dec: Do not alter avctx->rc_buffer_size" James Almer 2023-09-04 15:37 ` Andreas Rheinhardt 2023-09-04 22:10 ` James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 12/17] avformat/demux: propagate the internal decoder's bitrate properties James Almer 2023-09-04 22:11 ` James Almer 2023-09-04 15:04 ` James Almer [this message] 2023-09-04 22:11 ` [FFmpeg-devel] [PATCH 14/17] avcodec/avcodec: deprecate coded_side_data James Almer 2023-09-04 15:04 ` James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 15/17] avcodec/utils: move ff_add_cpb_side_data() to encoder code James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 16/17] avformat/demux: stop copying the internal AVCodecContext coded_side_data James Almer 2023-09-04 15:04 ` [FFmpeg-devel] [PATCH 17/17] fftools: stop propagating the encoder's coded_side_data James Almer 2023-09-04 15:37 ` [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data Derek Buitenhuis 2023-09-04 16:10 ` James Almer 2023-09-05 13:19 ` Derek Buitenhuis 2023-09-05 13:31 ` James Almer 2023-09-05 14:06 ` Derek Buitenhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230904150411.56777-14-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git