From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F07EC472CD for ; Mon, 4 Sep 2023 14:34:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 57C6C68C6B5; Mon, 4 Sep 2023 17:34:23 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7200768B683 for ; Mon, 4 Sep 2023 17:34:16 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id A5FB440025 for ; Mon, 4 Sep 2023 14:34:15 +0000 (UTC) Date: Mon, 4 Sep 2023 16:34:14 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230904143414.GH8640@pb2> References: <20230902160741.19197-1-nuomi2021@gmail.com> <20230904142857.GG8640@pb2> MIME-Version: 1.0 In-Reply-To: <20230904142857.GG8640@pb2> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3 14/14] vvcdec: add full vvc decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1121047761043715838==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1121047761043715838== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0XhtP95kHFp3KGBe" Content-Disposition: inline --0XhtP95kHFp3KGBe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 04, 2023 at 04:28:57PM +0200, Michael Niedermayer wrote: > On Sun, Sep 03, 2023 at 12:07:41AM +0800, Nuo Mi wrote: > > vvc decoder plug-in to avcodec. > > split frames into slices/tiles and send them to vvc_thread for further = decoding > > reorder and wait for the frame decoding to be done and output the frame > >=20 > > Features: > > + Support I, P, B frames > > + Support 8/10/12 bits, chroma 400, 420, 422, and 444 and range ext= ension > > + Support VVC new tools like MIP, CCLM, AFFINE, GPM, DMVR, PROF, BD= OF, LMCS, ALF > > + 295 conformace clips passed > > - Not support RPR, IBC, PALETTE, and other minor features yet > >=20 > > Performance: > > C code FPS on i7-12700 (x86): > > BQTerrace_1920x1080_60_10_420_22_RA.vvc 77.7 > > Chimera_8bit_1080P_1000_frames.vvc 174.3 > > NovosobornayaSquare_1920x1080.bin 163.7 > > RitualDance_1920x1080_60_10_420_32_LD.266 136.7 > > RitualDance_1920x1080_60_10_420_37_RA.266 154.3 > > Tango2_3840x2160_60_10_420_27_LD.266 30.0 > > Tango2_3840x2160_60_10_420_27_RA.266 29.0 > >=20 > > C code FPS on M1 Mac Pro (ARM): > > BQTerrace_1920x1080_60_10_420_22_RA.vvc 58.7 > > Chimera_8bit_1080P_1000_frames.vvc 153.3 > > NovosobornayaSquare_1920x1080.bin 150.3 > > RitualDance_1920x1080_60_10_420_32_LD.266 105.0 > > RitualDance_1920x1080_60_10_420_37_RA.266 133.0 > > Tango2_3840x2160_60_10_420_27_LD.266 21.7 > >=20 > > Asm optimizations still working in progress. please check > > https://github.com/ffvvc/FFmpeg/wiki#performance-data for the latest > >=20 > > Contributors(based on code merge order): > > Nuo Mi > > Xu Mu > > frankplow > > Shaun Loo > > --- > > libavcodec/vvc/vvcdec.c | 1025 ++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 1024 insertions(+), 1 deletion(-) >=20 > are the fate tests like fate-cbs-vvc-SUBPIC_A_3 supposed to take really l= ong > after this ? >=20 > (really long meaning longer than my patience before killing the task) Heres a backtrace when i stop it [vvc @ 0x555558699e40] Skipping NAL unit 19 [vvc @ 0x555558699e40] Skipping NAL unit 24 [vvc @ 0x555558699e40] Skipping NAL unit 19 [vvc @ 0x555558699e40] Skipping NAL unit 24 [vvc @ 0x555558699e40] Skipping NAL unit 19 ^C Thread 1 "ffmpeg_g" received signal SIGINT, Interrupt. __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 135 ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: No such file or direc= tory. (gdb) bt #0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:= 135 #1 0x00007ffff00c4025 in __GI___pthread_mutex_lock (mutex=3D0x5555586d3540= ) at ../nptl/pthread_mutex_lock.c:80 #2 0x00005555567d24d5 in strict_pthread_mutex_lock (mutex=3D0x5555586d3540= ) at libavutil/thread.h:91 #3 0x00005555567d2e6c in av_executor_execute (e=3D0x5555586d3500, t=3D0x55= 5558dc7900) at libavutil/executor.c:187 #4 0x0000555556642195 in ff_vvc_frame_add_task (s=3D0x55555869b400, t=3D0x= 555558dc7900) at libavcodec/vvc/vvc_thread.c:770 #5 0x000055555627f997 in decode_slice (s=3D0x55555869b400, fc=3D0x7ffff7f3= b0b0, nal=3D0x555558721f30, unit=3D0x55555873e498) at libavcodec/vvc/vvcdec= =2Ec:825 #6 0x000055555627fa48 in decode_nal_unit (s=3D0x55555869b400, fc=3D0x7ffff= 7f3b0b0, nal=3D0x555558721f30, unit=3D0x55555873e498) at libavcodec/vvc/vvc= dec.c:851 #7 0x000055555627fc11 in decode_nal_units (s=3D0x55555869b400, fc=3D0x7fff= f7f3b0b0, avpkt=3D0x55555869ba00) at libavcodec/vvc/vvcdec.c:897 #8 0x0000555556280007 in vvc_decode_frame (avctx=3D0x555558699e40, output= =3D0x55555869b0c0, got_output=3D0x7fffffffd400, avpkt=3D0x55555869ba00) at = libavcodec/vvc/vvcdec.c:989 #9 0x0000555555d9fa3c in decode_simple_internal (avctx=3D0x555558699e40, f= rame=3D0x55555869b0c0, discarded_samples=3D0x7fffffffd460) at libavcodec/de= code.c:432 #10 0x0000555555d9ff93 in decode_simple_receive_frame (avctx=3D0x555558699e= 40, frame=3D0x55555869b0c0) at libavcodec/decode.c:606 #11 0x0000555555da0103 in decode_receive_frame_internal (avctx=3D0x55555869= 9e40, frame=3D0x55555869b0c0) at libavcodec/decode.c:634 #12 0x0000555555da04c8 in avcodec_send_packet (avctx=3D0x555558699e40, avpk= t=3D0x555559917c88) at libavcodec/decode.c:731 #13 0x0000555555a9d3d8 in try_decode_frame (s=3D0x555558698900, st=3D0x5555= 586999c0, pkt=3D0x555559917c88, options=3D0x55555869a3c0) at libavformat/de= mux.c:2075 #14 0x0000555555aa01f2 in avformat_find_stream_info (ic=3D0x555558698900, o= ptions=3D0x55555869a3c0) at libavformat/demux.c:2771 #15 0x0000555555697446 in ifile_open (o=3D0x7fffffffdaa0, filename=3D0x7fff= ffffe56b "fate-suite//vvc-conformance/SUBPIC_A_3.bit") at fftools/ffmpeg_de= mux.c:1538 #16 0x00005555556baaf6 in open_files (l=3D0x555558698218, inout=3D0x5555568= 7dc92 "input", open_file=3D0x555555696649 ) at fftools/ffmpeg_o= pt.c:1284 #17 0x00005555556bac9e in ffmpeg_parse_options (argc=3D22, argv=3D0x7ffffff= fe1c8) at fftools/ffmpeg_opt.c:1324 #18 0x00005555556c8c06 in main (argc=3D22, argv=3D0x7fffffffe1c8) at fftool= s/ffmpeg.c:1314 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein --0XhtP95kHFp3KGBe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZPXq5gAKCRBhHseHBAsP q98eAJ4pPX8UrRdZPNjbr2OXsmGNF7CQCwCgm9XCfx3CQwFyWvVZMVRJVk5bxLE= =LhhM -----END PGP SIGNATURE----- --0XhtP95kHFp3KGBe-- --===============1121047761043715838== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1121047761043715838==--