From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA009472C1 for ; Mon, 4 Sep 2023 14:05:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0196868C705; Mon, 4 Sep 2023 17:05:50 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 72BEA68C688 for ; Mon, 4 Sep 2023 17:05:44 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9717F60008 for ; Mon, 4 Sep 2023 14:05:43 +0000 (UTC) Date: Mon, 4 Sep 2023 16:05:42 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230904140542.GF8640@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8588374101502683020==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8588374101502683020== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yRA+Bmk8aPhU85Qt" Content-Disposition: inline --yRA+Bmk8aPhU85Qt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 02, 2023 at 06:21:40PM +0200, Andreas Rheinhardt wrote: > It is not necessary at all. So remove it. > This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h. the mingw64 build seems not to like this In file included from src/libavutil/getenv_utf8.h:29:0, from src/libavformat/ipfsgateway.c:24: src/libavutil/wchar_filename.h: In function =E2=80=98utf8towchar=E2=80=99: src/libavutil/wchar_filename.h:34:17: error: =E2=80=98EINVAL=E2=80=99 undec= lared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:34:17: note: each undeclared identifier is r= eported only once for each function it appears in src/libavutil/wchar_filename.h:39:17: error: =E2=80=98ENOMEM=E2=80=99 undec= lared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/libavutil/wchar_filename.h: In function =E2=80=98wchartocp=E2=80=99: src/libavutil/wchar_filename.h:55:17: error: =E2=80=98EINVAL=E2=80=99 undec= lared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:60:17: error: =E2=80=98ENOMEM=E2=80=99 undec= lared (first use in this function) errno =3D ENOMEM; ^~~~~~ In file included from src/libavutil/getenv_utf8.h:29:0, from src/libavformat/ipfsgateway.c:24: src/libavutil/wchar_filename.h: In function =E2=80=98get_full_path_name=E2= =80=99: src/libavutil/wchar_filename.h:137:17: error: =E2=80=98EINVAL=E2=80=99 unde= clared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:143:17: error: =E2=80=98ENOMEM=E2=80=99 unde= clared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/libavutil/wchar_filename.h: In function =E2=80=98add_extended_prefix=E2= =80=99: src/libavutil/wchar_filename.h:211:21: error: =E2=80=98ENOMEM=E2=80=99 unde= clared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/ffbuild/common.mak:81: recipe for target 'libavformat/ipfsgateway.o' fa= iled make: *** [libavformat/ipfsgateway.o] Error 1 make: *** Waiting for unfinished jobs.... In file included from src/libavutil/getenv_utf8.h:29:0, from src/libavformat/http.c:33: src/libavutil/wchar_filename.h: In function =E2=80=98utf8towchar=E2=80=99: src/libavutil/wchar_filename.h:34:17: error: =E2=80=98EINVAL=E2=80=99 undec= lared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:34:17: note: each undeclared identifier is r= eported only once for each function it appears in src/libavutil/wchar_filename.h:39:17: error: =E2=80=98ENOMEM=E2=80=99 undec= lared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/libavutil/wchar_filename.h: In function =E2=80=98wchartocp=E2=80=99: src/libavutil/wchar_filename.h:55:17: error: =E2=80=98EINVAL=E2=80=99 undec= lared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:60:17: error: =E2=80=98ENOMEM=E2=80=99 undec= lared (first use in this function) errno =3D ENOMEM; ^~~~~~ In file included from src/libavutil/getenv_utf8.h:29:0, from src/libavformat/http.c:33: src/libavutil/wchar_filename.h: In function =E2=80=98get_full_path_name=E2= =80=99: src/libavutil/wchar_filename.h:137:17: error: =E2=80=98EINVAL=E2=80=99 unde= clared (first use in this function); did you mean =E2=80=98WINVER=E2=80=99? errno =3D EINVAL; ^~~~~~ WINVER src/libavutil/wchar_filename.h:143:17: error: =E2=80=98ENOMEM=E2=80=99 unde= clared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/libavutil/wchar_filename.h: In function =E2=80=98add_extended_prefix=E2= =80=99: src/libavutil/wchar_filename.h:211:21: error: =E2=80=98ENOMEM=E2=80=99 unde= clared (first use in this function) errno =3D ENOMEM; ^~~~~~ src/ffbuild/common.mak:81: recipe for target 'libavformat/http.o' failed make: *** [libavformat/http.o] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact --yRA+Bmk8aPhU85Qt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZPXkMwAKCRBhHseHBAsP q53wAJ9Xq6Y2MlI4TI5QhRvKtBa9swylvACfaqh9dQXY3u4OS4HhrtmuovR9D44= =lkMy -----END PGP SIGNATURE----- --yRA+Bmk8aPhU85Qt-- --===============8588374101502683020== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8588374101502683020==--