From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h
Date: Mon, 4 Sep 2023 16:05:42 +0200
Message-ID: <20230904140542.GF8640@pb2> (raw)
In-Reply-To: <AS8P250MB074407BDF4491D26E263A1E08FEBA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
[-- Attachment #1.1: Type: text/plain, Size: 4428 bytes --]
On Sat, Sep 02, 2023 at 06:21:40PM +0200, Andreas Rheinhardt wrote:
> It is not necessary at all. So remove it.
> This also breaks an inclusion cycle mem.h->avutil.h->common.h->mem.h.
the mingw64 build seems not to like this
In file included from src/libavutil/getenv_utf8.h:29:0,
from src/libavformat/ipfsgateway.c:24:
src/libavutil/wchar_filename.h: In function ‘utf8towchar’:
src/libavutil/wchar_filename.h:34:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:34:17: note: each undeclared identifier is reported only once for each function it appears in
src/libavutil/wchar_filename.h:39:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/libavutil/wchar_filename.h: In function ‘wchartocp’:
src/libavutil/wchar_filename.h:55:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:60:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
In file included from src/libavutil/getenv_utf8.h:29:0,
from src/libavformat/ipfsgateway.c:24:
src/libavutil/wchar_filename.h: In function ‘get_full_path_name’:
src/libavutil/wchar_filename.h:137:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:143:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/libavutil/wchar_filename.h: In function ‘add_extended_prefix’:
src/libavutil/wchar_filename.h:211:21: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/ffbuild/common.mak:81: recipe for target 'libavformat/ipfsgateway.o' failed
make: *** [libavformat/ipfsgateway.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from src/libavutil/getenv_utf8.h:29:0,
from src/libavformat/http.c:33:
src/libavutil/wchar_filename.h: In function ‘utf8towchar’:
src/libavutil/wchar_filename.h:34:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:34:17: note: each undeclared identifier is reported only once for each function it appears in
src/libavutil/wchar_filename.h:39:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/libavutil/wchar_filename.h: In function ‘wchartocp’:
src/libavutil/wchar_filename.h:55:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:60:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
In file included from src/libavutil/getenv_utf8.h:29:0,
from src/libavformat/http.c:33:
src/libavutil/wchar_filename.h: In function ‘get_full_path_name’:
src/libavutil/wchar_filename.h:137:17: error: ‘EINVAL’ undeclared (first use in this function); did you mean ‘WINVER’?
errno = EINVAL;
^~~~~~
WINVER
src/libavutil/wchar_filename.h:143:17: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/libavutil/wchar_filename.h: In function ‘add_extended_prefix’:
src/libavutil/wchar_filename.h:211:21: error: ‘ENOMEM’ undeclared (first use in this function)
errno = ENOMEM;
^~~~~~
src/ffbuild/common.mak:81: recipe for target 'libavformat/http.o' failed
make: *** [libavformat/http.o] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-04 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 11:31 [FFmpeg-devel] [PATCH] avformat/avformat: Avoid including codec.h, frame.h Andreas Rheinhardt
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 2/7] avcodec/defs: Add AV_PROFILE_* defines, deprecate FF_PROFILE_* defines Andreas Rheinhardt
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 3/7] avformat/mux: Only write HEADER marker if format has .write_header Andreas Rheinhardt
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 4/7] avformat/aviobuf: Add ffio_init_(read|write)_context() Andreas Rheinhardt
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 5/7] avutil: Move error.h from avutil.h to common.h Andreas Rheinhardt
2023-09-03 7:47 ` Paul B Mahol
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 6/7] avutil/mem: Don't include avutil.h Andreas Rheinhardt
2023-09-03 7:43 ` Paul B Mahol
2023-09-04 14:05 ` Michael Niedermayer [this message]
2023-09-04 14:20 ` Andreas Rheinhardt
2023-09-02 16:21 ` [FFmpeg-devel] [PATCH 7/7] avutil/avstring: Remove obsolete version.h inclusion Andreas Rheinhardt
2023-09-02 23:12 ` [FFmpeg-devel] [PATCH 8/8] all: Replace __FUNCTION__ by __func__ Andreas Rheinhardt
2023-09-02 23:40 ` James Almer
2023-09-03 9:05 ` Andreas Rheinhardt
2023-09-02 23:28 ` [FFmpeg-devel] [PATCH 9/9] avcodec/vp8data: Use <> for inclusion of stdint.h Andreas Rheinhardt
2023-09-03 7:47 ` Paul B Mahol
2023-09-03 14:22 ` [FFmpeg-devel] [PATCH 10/11] avfilter/af_volume: Also deprecate position enum value Andreas Rheinhardt
2023-09-03 14:22 ` [FFmpeg-devel] [PATCH 11/11] avfilter/f_select: Also deprecate "pos" variable name Andreas Rheinhardt
2023-09-04 14:17 ` [FFmpeg-devel] [PATCH v2 6/11] avutil/mem: Don't include avutil.h Andreas Rheinhardt
2023-09-06 9:36 ` [FFmpeg-devel] [PATCH] avformat/avformat: Avoid including codec.h, frame.h Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904140542.GF8640@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git