* [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error
@ 2023-08-28 7:14 Tong Wu
2023-08-29 13:44 ` "zhilizhao(赵志立)"
2023-08-29 13:46 ` James Almer
0 siblings, 2 replies; 3+ messages in thread
From: Tong Wu @ 2023-08-28 7:14 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tong Wu
Compiler: MSVC 14.35.32215
Error type: error C2099: initializer is not a constant
Related commit: 0c0dd23 avcodec/jpegxl_parser: add JPEG XL parser
Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
libavcodec/jpegxl_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
index 66e64b1074..20c8a41a89 100644
--- a/libavcodec/jpegxl_parser.c
+++ b/libavcodec/jpegxl_parser.c
@@ -49,7 +49,7 @@
#define clog1p(x) (ff_log2(x) + !!(x))
#define unpack_signed(x) (((x) & 1 ? -(x)-1 : (x))/2)
#define div_ceil(x, y) (((x) - 1) / (y) + 1)
-#define vlm(a,b) (VLCElem){.sym = (a), .len = (b)}
+#define vlm(a,b) {.sym = (a), .len = (b)}
typedef struct JXLHybridUintConf {
int split_exponent;
--
2.41.0.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error
2023-08-28 7:14 [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error Tong Wu
@ 2023-08-29 13:44 ` "zhilizhao(赵志立)"
2023-08-29 13:46 ` James Almer
1 sibling, 0 replies; 3+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-08-29 13:44 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Wu, Tong1
> On Aug 28, 2023, at 15:14, Tong Wu <tong1.wu-at-intel.com@ffmpeg.org> wrote:
>
> Compiler: MSVC 14.35.32215
> Error type: error C2099: initializer is not a constant
> Related commit: 0c0dd23 avcodec/jpegxl_parser: add JPEG XL parser
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavcodec/jpegxl_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
> index 66e64b1074..20c8a41a89 100644
> --- a/libavcodec/jpegxl_parser.c
> +++ b/libavcodec/jpegxl_parser.c
> @@ -49,7 +49,7 @@
> #define clog1p(x) (ff_log2(x) + !!(x))
> #define unpack_signed(x) (((x) & 1 ? -(x)-1 : (x))/2)
> #define div_ceil(x, y) (((x) - 1) / (y) + 1)
> -#define vlm(a,b) (VLCElem){.sym = (a), .len = (b)}
> +#define vlm(a,b) {.sym = (a), .len = (b)}
LGTM. GCC complains the same with -pedantic.
>
> typedef struct JXLHybridUintConf {
> int split_exponent;
> --
> 2.41.0.windows.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error
2023-08-28 7:14 [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error Tong Wu
2023-08-29 13:44 ` "zhilizhao(赵志立)"
@ 2023-08-29 13:46 ` James Almer
1 sibling, 0 replies; 3+ messages in thread
From: James Almer @ 2023-08-29 13:46 UTC (permalink / raw)
To: ffmpeg-devel
On 8/28/2023 4:14 AM, Tong Wu wrote:
> Compiler: MSVC 14.35.32215
> Error type: error C2099: initializer is not a constant
> Related commit: 0c0dd23 avcodec/jpegxl_parser: add JPEG XL parser
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavcodec/jpegxl_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c
> index 66e64b1074..20c8a41a89 100644
> --- a/libavcodec/jpegxl_parser.c
> +++ b/libavcodec/jpegxl_parser.c
> @@ -49,7 +49,7 @@
> #define clog1p(x) (ff_log2(x) + !!(x))
> #define unpack_signed(x) (((x) & 1 ? -(x)-1 : (x))/2)
> #define div_ceil(x, y) (((x) - 1) / (y) + 1)
> -#define vlm(a,b) (VLCElem){.sym = (a), .len = (b)}
> +#define vlm(a,b) {.sym = (a), .len = (b)}
>
> typedef struct JXLHybridUintConf {
> int split_exponent;
Applied (last night, but forgot to reply). Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-29 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-28 7:14 [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix a compile error Tong Wu
2023-08-29 13:44 ` "zhilizhao(赵志立)"
2023-08-29 13:46 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git