From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A966547124 for ; Sun, 27 Aug 2023 23:29:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 76B3568C5F5; Mon, 28 Aug 2023 02:29:16 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C97CB68C3C0 for ; Mon, 28 Aug 2023 02:29:09 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 06D4240002 for ; Sun, 27 Aug 2023 23:29:08 +0000 (UTC) Date: Mon, 28 Aug 2023 01:29:07 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230827232907.GY7802@pb2> References: <20230826165350.8838-1-michael@niedermayer.cc> <20230826165350.8838-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20230826165350.8838-2-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Implement interim mode detection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6175666947493795483==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6175666947493795483== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GQNAPbQMu08Y9hOK" Content-Disposition: inline --GQNAPbQMu08Y9hOK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 26, 2023 at 06:53:50PM +0200, Michael Niedermayer wrote: > Fixes: NoLegacy.ape > Found-by: Matt Ashland > Signed-off-by: Michael Niedermayer > --- > libavcodec/apedec.c | 106 +++++++++++++++++++++++++++++++++++--------- > 1 file changed, 84 insertions(+), 22 deletions(-) Also, the same issue should exists in the mono codepath. I have no testcase for mono, so left this unchanged for now, as i cannot test it. But if someone has a testcase, tell me It also may be needed to wait till one of the CRCs to distinguish between the 2 decoding forms. (this is how the SDK does it) Waiting for some CRC is a bit inconvenient as we return data before currently. And this quicker variant here works for all files i have We also differ from the SDK by decoding both forms in parallel until one fails. The advantage here is that if only one is decoded then a random failure cannot be distinguished from "interim mode" which would result in a bitstream error causing a switch to the wrong mode. Above is how its done ATM in git master. As more issues get submitted that may change thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --GQNAPbQMu08Y9hOK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZOvcQAAKCRBhHseHBAsP q1PsAJ92X5RhACD21ZcR85AN2gl4XG2JEACfSE8k1ihMjeodlU3I5G8/DDl9ZPQ= =j0IC -----END PGP SIGNATURE----- --GQNAPbQMu08Y9hOK-- --===============6175666947493795483== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6175666947493795483==--