From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2AFFE470F6 for ; Sat, 26 Aug 2023 20:20:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A90FA68C5BF; Sat, 26 Aug 2023 23:20:36 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B027068C40B for ; Sat, 26 Aug 2023 23:20:29 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8714C60002 for ; Sat, 26 Aug 2023 20:20:28 +0000 (UTC) Date: Sat, 26 Aug 2023 22:20:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230826202027.GU7802@pb2> References: <20230826151144.24858-1-anton@khirnov.net> <20230826151144.24858-4-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230826151144.24858-4-anton@khirnov.net> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 04/18] fftools/ffmpeg_mux: stop rescaling timestamps in of_streamcopy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1153520438052799424==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1153520438052799424== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PYp1mWY1rKQXbk9H" Content-Disposition: inline --PYp1mWY1rKQXbk9H Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 26, 2023 at 05:11:30PM +0200, Anton Khirnov wrote: > This function converts packet timestamps from the input stream timebase > to OutputStream.mux_timebase, which may or may not be equal to the > actual output AVStream timebase (and even when it is, this may not > always be the optimal choice due to bitstream filtering). >=20 > Just keep the timestamps in input stream timebase, they will be rescaled > as needed before bitstream filtering and/or sending the packet to the > muxer. >=20 > Drop now-unused OutputStream.mux_timebase. > --- > fftools/ffmpeg.h | 2 -- > fftools/ffmpeg_enc.c | 2 -- > fftools/ffmpeg_mux.c | 21 +++++++-------------- > fftools/ffmpeg_mux_init.c | 2 -- > 4 files changed, 7 insertions(+), 20 deletions(-) =2E/ffmpeg -i in.flv -t 0.2 -bitexact -acodec copy -y /tmp/copy.mov (this= ffmpeg version matters) =2E/ffmpeg -i /tmp/copy.mov -bitexact -f framecrc - (this= ffmpeg version doesnt matter) 0, 0, 0, 1152, 4608, 0xa25d01fe 0, 1152, 1152, 1152, 4608, 0x3b9ff171 0, 2304, 2304, 1152, 4608, 0x10ad7d49 0, 3456, 3456, 1152, 4608, 0xadae4ea6 0, 4608, 4608, 1152, 4608, 0xaba106e7 0, 5760, 5760, 1152, 4608, 0x1beee538 0, 6912, 6912, 1152, 4608, 0x7dbe78ef 0, 8064, 8064, 1152, 4608, 0xaf41b247 after the commit: 0, 0, 0, 1152, 4608, 0xa25d01fe 0, 1147, 1147, 1152, 4608, 0x3b9ff171 0, 2293, 2293, 1152, 4608, 0x10ad7d49 0, 3440, 3440, 1152, 4608, 0xadae4ea6 0, 4586, 4586, 1152, 4608, 0xaba106e7 0, 5777, 5777, 1152, 4608, 0x1beee538 0, 6924, 6924, 1152, 4608, 0x7dbe78ef 0, 8070, 8070, 1152, 4608, 0xaf41b247 Here the timestamps stored in a newly muxed file seems bad could be missing something but that seems bad, even if the input is only 1ms precisse we need to generate valid timestamps if we remux I suspect every mp3 in flv will show this effect but if not i can share in.= flv thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --PYp1mWY1rKQXbk9H Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZOpehwAKCRBhHseHBAsP qxtrAKCIIl83FyyvXGyJVgp6IRLVmMtM0gCfUZ5mWW235kJ2kGJn6Wpp0chrR9Q= =pf8Y -----END PGP SIGNATURE----- --PYp1mWY1rKQXbk9H-- --===============1153520438052799424== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1153520438052799424==--