From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTP id C1E17468FB
for <ffmpegdev@gitmailbox.com>; Wed, 23 Aug 2023 22:36:23 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EAAD668C579;
Thu, 24 Aug 2023 01:36:20 +0300 (EEST)
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
[217.70.183.199])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D06C68B79A
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Aug 2023 01:36:14 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id E97C3FF804
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Aug 2023 22:36:13 +0000 (UTC)
Date: Thu, 24 Aug 2023 00:36:13 +0200
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20230823223613.GK7802@pb2>
References: <CAPYw7P5=iK4upnHx0WhnJqMO3h=KX7fbf-Pbq4u-jrB7OwomgQ@mail.gmail.com>
<20230816163803.GT7802@pb2>
<CAPYw7P7FFbBQotv9ZVbotSyTW4TkD8dnQD_Y8eEGvqufhLKuTg@mail.gmail.com>
<20230823190226.GG7802@pb2>
<CAPYw7P6iBZ=_X9fCe4imMcrLNWTrouu7cyLj5+f3fayyXy5Lgg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAPYw7P6iBZ=_X9fCe4imMcrLNWTrouu7cyLj5+f3fayyXy5Lgg@mail.gmail.com>
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============9216235795948593279=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20230823223613.GK7802@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============9216235795948593279==
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="SsabpE+XP4P+grto"
Content-Disposition: inline
--SsabpE+XP4P+grto
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol wrote:
> On Wed, Aug 23, 2023 at 9:02=E2=80=AFPM Michael Niedermayer <michael@nied=
ermayer.cc>
> wrote:
>=20
> > On Wed, Aug 16, 2023 at 06:53:42PM +0200, Paul B Mahol wrote:
> > > On Wed, Aug 16, 2023 at 6:38=E2=80=AFPM Michael Niedermayer <
> > michael@niedermayer.cc>
> > > wrote:
> > >
> > > > On Tue, Aug 15, 2023 at 04:49:05PM +0200, Paul B Mahol wrote:
> > > > > Attached
> > > >
> > > > [...]
> > > > > adpcm.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 3305dbe07ca935958fa213f5cadc339ad3cc3592
> > > > 0003-avcodec-adpcm-use-already-existing-pointer-for-4xm-d.patch
> > > > > From c6ad6dc7b8725d897e36399e5c7b8174caeb92e6 Mon Sep 17 00:00:00
> > 2001
> > > > > From: Paul B Mahol <onemda@gmail.com>
> > > > > Date: Tue, 15 Aug 2023 14:18:47 +0200
> > > > > Subject: [PATCH 3/4] avcodec/adpcm: use already existing pointer =
for
> > 4xm
> > > > > decoder
> > > > >
> > > > > Signed-off-by: Paul B Mahol <onemda@gmail.com>
> > > > > ---
> > > > > libavcodec/adpcm.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> > > > > index b0c3b91a3b..9993c9e531 100644
> > > > > --- a/libavcodec/adpcm.c
> > > > > +++ b/libavcodec/adpcm.c
> > > > > @@ -1211,7 +1211,7 @@ static int adpcm_decode_frame(AVCodecContext
> > > > *avctx, AVFrame *frame,
> > > > >
> > > > > for (int i =3D 0; i < channels; i++) {
> > > > > ADPCMChannelStatus *cs =3D &c->status[i];
> > > > > - samples =3D (int16_t *)frame->data[i];
> > > > > + samples =3D samples_p[i];
> > > > > for (int n =3D nb_samples >> 1; n > 0; n--) {
> > > > > int v =3D bytestream2_get_byteu(&gb);
> > > > > *samples++ =3D adpcm_ima_expand_nibble(cs, v & 0=
x0F,
> > 4);
> > > >
> > > > should be ok if tested
> > > >
> > > >
> > > > > --
> > > > > 2.39.1
> > > > >
> > > >
> > > > > libavcodec/adpcm.c | 388
> > > > +++++++++++++++++----------------
> > > > > tests/ref/fate/adpcm-creative-8-2.6bit | 2
> > > > > tests/ref/fate/adpcm-creative-8-2bit | 2
> > > > > tests/ref/fate/adpcm-creative-8-4bit | 2
> > > > > tests/ref/fate/adpcm-ms-mono | 60 +----
> > > > > 5 files changed, 227 insertions(+), 227 deletions(-)
> > > > > 1760df1de66b4227e71ffe942dedcf7d8a33ad48
> > > > 0004-avcodec-adpcm-consume-all-input-when-decoding.patch
> > > > > From 19789bca53548d672bff30b88a8838edaa876bdb Mon Sep 17 00:00:00
> > 2001
> > > > > From: Paul B Mahol <onemda@gmail.com>
> > > > > Date: Tue, 15 Aug 2023 15:25:22 +0200
> > > > > Subject: [PATCH 4/4] avcodec/adpcm: consume all input when decodi=
ng
> > > > >
> > > > > Stops multiple decoding calls for single packet.
> > > > > Also makes decoding faster.
> > > >
> > > > This increases latency, which can be problem if packets are
> > > > sufficiently large
> > > >
> > >
> > > Then reduce size at demuxer level. there is option for it.
> >
> > if that is so, then please explain exactly which option should be used
> > in the commit message
> >
> >
> ffmpeg -h demuxer=3Dwav
what about the demuxers that are not named "wav" ?
git grep -l ADPCM libavformat/*c | wc -l
88
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is a danger to trust the dream we wish for rather than
the science we have, -- Dr. Kenneth Brown
--SsabpE+XP4P+grto
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZOaJ2QAKCRBhHseHBAsP
q1jQAJ90Wydp/llDjSOKNOqBnfCZPNLiuQCfYV5FSGYDa2UsXV1hqMr7a3P7ARs=
=2fp9
-----END PGP SIGNATURE-----
--SsabpE+XP4P+grto--
--===============9216235795948593279==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============9216235795948593279==--