From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [RFC PATCH] avutil/avutil: make AV_TIME_BASE_Q available in C++
Date: Tue, 22 Aug 2023 14:29:44 +0200 (CEST)
Message-ID: <20230822122944.D1DA91601B9@lain.khirnov.net> (raw)
In-Reply-To: <tencent_9C6A0201BD68527CF2AC123AEDC3E1B5E40A@qq.com>
Quoting Zhao Zhili (2023-08-18 20: 11:31)
> From: Zhao Zhili <zhilizhao@tencent.com>
Date: Tue, 22 Aug 2023 14:29:44 +0200
Message-ID: <169270738483.26513.18411031229205897825@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
>
> It still different than AV_TIME_BASE_Q in C, like you cannot take
> address of AV_TIME_BASE_Q in C++. It's better than nothing.
> ---
> libavutil/avutil.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavutil/avutil.h b/libavutil/avutil.h
> index 64b68bdbd3..5201cc6c5e 100644
> --- a/libavutil/avutil.h
> +++ b/libavutil/avutil.h
> @@ -257,7 +257,12 @@ const char *av_get_media_type_string(enum AVMediaType media_type);
> * Internal time base represented as fractional value
> */
>
> +#ifdef __cplusplus
> +/* ISO C++ forbids compound-literals. */
> +#define AV_TIME_BASE_Q AVRational{1, AV_TIME_BASE}
How about av_make_q(1, AV_TIME_BASE_Q)? I don't know how the above
syntax works.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-08-22 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 18:11 Zhao Zhili
2023-08-18 18:57 ` Michael Niedermayer
2023-08-22 12:29 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822122944.D1DA91601B9@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git