From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4F4844658F for ; Sun, 20 Aug 2023 13:12:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D4F768C16A; Sun, 20 Aug 2023 16:12:27 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BBD068B631 for ; Sun, 20 Aug 2023 16:12:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 82AE3E0003 for ; Sun, 20 Aug 2023 13:12:19 +0000 (UTC) Date: Sun, 20 Aug 2023 15:12:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230820131218.GB7802@pb2> References: <20230817214858.184010-1-jeebjp@gmail.com> <20230817214858.184010-12-jeebjp@gmail.com> <20230819165327.GA7802@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0092907805426244194==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0092907805426244194== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PIQBdKJ4iu1leRZl" Content-Disposition: inline --PIQBdKJ4iu1leRZl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 20, 2023 at 01:25:27AM +0300, Jan Ekstr=C3=B6m wrote: > On Sat, Aug 19, 2023 at 7:53=E2=80=AFPM Michael Niedermayer > wrote: > > > > On Fri, Aug 18, 2023 at 12:48:49AM +0300, Jan Ekstr=C3=B6m wrote: > > > Both of these two structures were first available with X264_BUILD > > > 163, so make relevant functionality conditional on the version > > > being at least such. > > > > > > Keep handle_side_data available in all cases as this way X264_init > > > does not require additional version based conditions within it. > > > > > > Finally, add a FATE test which verifies that pass-through of the > > > MDCV/CLL side data is working during encoding. > > > --- > > > libavcodec/libx264.c | 79 ++++++++++++++++++++++++++++++++++= ++ > > > tests/fate/enc_external.mak | 5 +++ > > > tests/ref/fate/libx264-hdr10 | 15 +++++++ > > > 3 files changed, 99 insertions(+) > > > create mode 100644 tests/ref/fate/libx264-hdr10 > > > > fate fails with X264_BUILD 152 > > > > The filters 'Parsed_null_0' and 'format' do not have a common format an= d automatic conversion is disabled. > > [vf#0:0 @ 0x55eddf8d4780] Error reinitializing filters! > > Failed to inject frame into filter network: Invalid argument > > Error while filtering: Invalid argument > > [out#0/mp4 @ 0x55eddf87b980] Nothing was written into output file, beca= use at least one of its streams received no packets. > > frame=3D 0 fps=3D0.0 q=3D0.0 Lsize=3D 0kB time=3DN/A bitrate= =3DN/A speed=3DN/A > > Conversion failed! > > threads=3D1 > > tests/Makefile:307: recipe for target 'fate-libx264-hdr10' failed > > make: *** [fate-libx264-hdr10] Error 234 > > >=20 > Without having more information, that sounds more like a 8bit only > build rather than an X264_BUILD related issue, as the error seems to > come from a conversion from the input 10bit content to whatever not > being available. >=20 > Can you check if that is the case? x264 152 was either 8bit or 10bit but not both. That box on which this fails has x264 builds for both for 8bit and 10bit. ffmpeg can at runtime be linked with either for example LD_PRELOAD=3D/usr/lib/x86_64-linux-gnu/x264-10bit/libx264.so.152 ./ffmpeg -= i ~/videos/mm-short.mpg test.mkv produces a 10bit output maybe you should just disable this test for 152 and prior to avoid this com= plexity thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --PIQBdKJ4iu1leRZl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZOIRLwAKCRBhHseHBAsP q0PrAJ9wvE38GbaSg0+Ni/ID0Kw1ZbisQQCfcsDv8jnXA5ias5AsmCWdLdqYF8I= =N9az -----END PGP SIGNATURE----- --PIQBdKJ4iu1leRZl-- --===============0092907805426244194== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0092907805426244194==--