Re: [FFmpeg-devel] [PATCH] tta decoder improvements

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] tta decoder improvements
Date: Wed, 16 Aug 2023 20:14:07 +0200
Message-ID: <20230816181407.GW7802@pb2> (raw)
In-Reply-To: <CAPYw7P6of-NO0ZgXR8hv1tHZ_T2HJfdjU_xo6LA2Cim88MqPHA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1761 bytes --]

On Wed, Aug 16, 2023 at 12:47:36PM +0200, Paul B Mahol wrote:
> Patch attached.

>  tta.c |  167 +++++++++++++++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 109 insertions(+), 58 deletions(-)
> a289f05b1ebb50604675a11894e254108e276714  0001-avcodec-tta-switch-to-planar-sample-formats.patch
> From 2b6ac4f7093157533b7f279a78a73bfabeb98cf0 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Tue, 15 Aug 2023 21:13:59 +0200
> Subject: [PATCH] avcodec/tta: switch to planar sample formats
> 
> Makes decoding few percent faster.
> Also fix code style while here.
> 
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  libavcodec/tta.c | 167 +++++++++++++++++++++++++++++++----------------
>  1 file changed, 109 insertions(+), 58 deletions(-)

breaks fate-lossless-tta

Stream mapping:
  Stream #0:0 -> #0:0 (tta (native) -> pcm_s16le (native))
The filters 'Parsed_anull_0' and 'format_out_0_0' do not have a common format and automatic conversion is disabled.
[af#0:0 @ 0x561fd8f3f280] Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while filtering: Invalid argument
[out#0/crc @ 0x561fd8f3c840] Nothing was written into output file, because at least one of its streams received no packets.
size=       0kB time=N/A bitrate=N/A speed=N/A
Conversion failed!
threads=1
tests/Makefile:308: recipe for target 'fate-lossless-tta' failed
make: *** [fate-lossless-tta] Error 234

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".