From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F3FC46E2A for ; Wed, 16 Aug 2023 16:49:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB8AA68C5B1; Wed, 16 Aug 2023 19:49:25 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 42DD968B6B0 for ; Wed, 16 Aug 2023 19:49:19 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 755C61BF20A for ; Wed, 16 Aug 2023 16:49:18 +0000 (UTC) Date: Wed, 16 Aug 2023 18:49:17 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230816164917.GU7802@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] tta decoder improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1011183368595408317==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1011183368595408317== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a6+ItBDHwozfXKFj" Content-Disposition: inline --a6+ItBDHwozfXKFj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2023 at 12:47:36PM +0200, Paul B Mahol wrote: > Patch attached. > tta.c | 167 +++++++++++++++++++++++++++++++++++++++++++----------------= ------- > 1 file changed, 109 insertions(+), 58 deletions(-) > a289f05b1ebb50604675a11894e254108e276714 0001-avcodec-tta-switch-to-plan= ar-sample-formats.patch > From 2b6ac4f7093157533b7f279a78a73bfabeb98cf0 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Tue, 15 Aug 2023 21:13:59 +0200 > Subject: [PATCH] avcodec/tta: switch to planar sample formats >=20 > Makes decoding few percent faster. great > Also fix code style while here. great too but these should be 2 seprate patches we can see also below the changes are unrelated and not limited to otherwise changed lines [...] > @@ -306,44 +310,24 @@ static int tta_decode_frame(AVCodecContext *avctx, = AVFrame *frame, > rice->sum1 +=3D value - (rice->sum1 >> 4); > if (rice->k1 > 0 && rice->sum1 < ff_tta_shift_16[rice->k1]) > rice->k1--; > - else if(rice->sum1 > ff_tta_shift_16[rice->k1 + 1]) > + else if (rice->sum1 > ff_tta_shift_16[rice->k1 + 1]) > rice->k1++; > value +=3D ff_tta_shift_1[rice->k0]; > default: > rice->sum0 +=3D value - (rice->sum0 >> 4); > if (rice->k0 > 0 && rice->sum0 < ff_tta_shift_16[rice->k0]) > rice->k0--; > - else if(rice->sum0 > ff_tta_shift_16[rice->k0 + 1]) > + else if (rice->sum0 > ff_tta_shift_16[rice->k0 + 1]) > rice->k0++; > } [...] > } > > -static av_cold int tta_decode_close(AVCodecContext *avctx) { > +static av_cold int tta_decode_close(AVCodecContext *avctx) > +{ > TTAContext *s =3D avctx->priv_data; > [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --a6+ItBDHwozfXKFj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNz+BgAKCRBhHseHBAsP q7GUAJ0T4evriwTHXNaKGJ9Wkbt1NN0B4QCfTFvKU0lagTlL7DFLTQPFvo0g6aQ= =+uBF -----END PGP SIGNATURE----- --a6+ItBDHwozfXKFj-- --===============1011183368595408317== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1011183368595408317==--