From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B75FD46DFC for ; Sat, 12 Aug 2023 15:19:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 48DED68C4B5; Sat, 12 Aug 2023 18:19:26 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E1A2A68C3B3 for ; Sat, 12 Aug 2023 18:19:19 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 34B0D20002 for ; Sat, 12 Aug 2023 15:19:18 +0000 (UTC) Date: Sat, 12 Aug 2023 17:19:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230812151918.GK7802@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6298636212713908601==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6298636212713908601== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V6eOyTo0I6mGr+IA" Content-Disposition: inline --V6eOyTo0I6mGr+IA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 07, 2023 at 09:02:19PM -0400, Brad Smith wrote: > lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang >=20 > libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of 'vec_xl'= must have the 'overloadable' attribute > --- > libswscale/ppc/yuv2rgb_altivec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_al= tivec.c > index 5e1033a973..6ef2441d8a 100644 > --- a/libswscale/ppc/yuv2rgb_altivec.c > +++ b/libswscale/ppc/yuv2rgb_altivec.c > @@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector = signed short Y, > * ---------------------------------------------------------------------= --------- > */ > =20 > -#if !HAVE_VSX > +#if !HAVE_VSX && !defined(__clang__) > static inline vector unsigned char vec_xl(signed long long offset, const= ubyte *addr) > { > const vector unsigned char *v_addr =3D (const vector unsigned char *= ) (addr + offset); > @@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long= long offset, const ubyte * > =20 > return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_p= erm); > } > -#endif /* !HAVE_VSX */ > +#endif /* !HAVE_VSX && !__clang__ */ Iam not altivec maintainer but i think the correct way to do this is to test for vec_xl() in configure and have some sort of HAVE_VEC_XL thats more robust than such chain of conditional checks thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your leaders based on what they did after the last election, not based on what they say before an election. --V6eOyTo0I6mGr+IA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNei8gAKCRBhHseHBAsP q+1hAJ0THlfXIOq7ljKJt4kLbdu3Z+DYiwCfaNM0jAmEevOjZWO3oO/PnUGDcbI= =LqLa -----END PGP SIGNATURE----- --V6eOyTo0I6mGr+IA-- --===============6298636212713908601== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6298636212713908601==--