From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46A8A45E59 for ; Sat, 12 Aug 2023 14:19:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C61E368C443; Sat, 12 Aug 2023 17:19:34 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9BC4B68BE58 for ; Sat, 12 Aug 2023 17:19:27 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0326720004 for ; Sat, 12 Aug 2023 14:19:26 +0000 (UTC) Date: Sat, 12 Aug 2023 16:19:26 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230812141926.GI7802@pb2> References: <20230810152704.6670-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] exclude currently unused 0.17% of fate samples from rsync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6946778976683041206==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6946778976683041206== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JJMoBJ7VTrzwkVuk" Content-Disposition: inline --JJMoBJ7VTrzwkVuk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 11, 2023 at 06:17:29PM +0200, Vittorio Giovara wrote: > On Thu, Aug 10, 2023 at 5:27=E2=80=AFPM Michael Niedermayer > wrote: >=20 > > Several developers where upset, that from the over 1gb of fate samples = 2mb > > are only used > > by the ffmpeg branch with SDR support in https://git.ffmpeg.org/libavra= dio > > > > This avoids these samples from being downloaded or synchronized. > > It should have no real world effect on anything of course if 0.17% more= or > > less is downloaded but maybe it makes some people happier. > > > > Signed-off-by: Michael Niedermayer > > --- > > configure | 2 ++ > > tests/Makefile | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/configure b/configure > > index 932998b8d6..f859701ebd 100755 > > --- a/configure > > +++ b/configure > > @@ -2384,6 +2384,7 @@ TOOLCHAIN_FEATURES=3D" > > inline_asm_nonlocal_labels > > pragma_deprecated > > rsync_contimeout > > + rsync_exclude > > symver_asm_label > > symver_gnu_asm > > vfp_args > > @@ -6968,6 +6969,7 @@ disabled makeinfo_html && texi2html --help 2> > > /dev/null | grep -q 'init-file' && > > perl -v > /dev/null 2>&1 && enable perl || disable perl > > pod2man --help > /dev/null 2>&1 && enable pod2man || disable pod= 2man > > rsync --help 2> /dev/null | grep -q 'contimeout' && enable > > rsync_contimeout || disable rsync_contimeout > > +rsync --help 2> /dev/null | grep -q -- '--exclude' && enable > > rsync_exclude || disable rsync_exclude > > xmllint --version > /dev/null 2>&1 && enable xmllint || disable xml= lint > > > > # check V4L2 codecs available in the API > > diff --git a/tests/Makefile b/tests/Makefile > > index e09f30a0fc..45db76695e 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -265,6 +265,7 @@ FATE_EXTERN +=3D $(FATE_EXTERN-ye= s) > > $(FATE_SAMPLES_FASTSTART) > > FATE +=3D $(FATE-yes) > > > > RSYNC_OPTIONS-$(HAVE_RSYNC_CONTIMEOUT) +=3D --contimeout=3D60 > > +RSYNC_OPTIONS-$(HAVE_RSYNC_EXCLUDE) +=3D --exclude=3D/sdr/ > > >=20 > This causes a list of folders to be maintained in the Makefile code which > I'm not sure is kosher Its only temporary. If we succeed implementing what jb suggested then there will be a sdr (demuxer/input) module in git master. And a new libavradio that module in git master will still need the testfiles, so when the module is added then these --exclude cases become unneeded > Would it not be simpler to just delete the sdr folder? on the client, it would cause it to be redownloaded, on the server, it would break libavradio, and especially when we are trying to refactor the code to move some of it into a seperate libav= radio (which i dont yet know how easy that will be) it will be important to ensure that nothing breaks when stuff is refactored so i would prefer to leave this on the server for ease of testing for every= one thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes --JJMoBJ7VTrzwkVuk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNeU6gAKCRBhHseHBAsP q1lFAJ9y9uM+TMl0IDuplu7p1/9IjgLdbwCfaHEUJ1l0TVbk/VaXszvylbT3pyY= =IJv1 -----END PGP SIGNATURE----- --JJMoBJ7VTrzwkVuk-- --===============6946778976683041206== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6946778976683041206==--