From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D74A47175 for ; Thu, 10 Aug 2023 15:13:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3995168C806; Thu, 10 Aug 2023 18:13:21 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 493EC68C806 for ; Thu, 10 Aug 2023 18:13:14 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9FDD660009 for ; Thu, 10 Aug 2023 15:13:13 +0000 (UTC) Date: Thu, 10 Aug 2023 17:13:12 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230810151312.GE7802@pb2> References: <20230810094758.GD7802@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] new audio filter and misc improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3415498571154342532==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3415498571154342532== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sJ8IagDoaaxT4KYQ" Content-Disposition: inline --sJ8IagDoaaxT4KYQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 10, 2023 at 12:10:49PM +0200, Paul B Mahol wrote: > On Thu, Aug 10, 2023 at 11:48=E2=80=AFAM Michael Niedermayer > wrote: >=20 > > On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > > > Patches attached. > > > > > af_adeclick.c | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 > > 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > > > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 21:53:04 +0200 > > > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless > > message > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > libavfilter/af_adeclick.c | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > [...] > > > > > af_adeclick.c | 136 > > ++++++++++++++++++++++++++++------------------------------ > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > cfc7bc440f2f408f8570501f3afb2de235860221 > > 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > > > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 21:49:19 +0200 > > > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > libavfilter/af_adeclick.c | 136 +++++++++++++++++++-----------------= -- > > > 1 file changed, 67 insertions(+), 69 deletions(-) > > > > [...] > > > > > doc/filters.texi | 51 +++++++++++++++++++++++++ > > > libavfilter/Makefile | 1 > > > libavfilter/af_adeclick.c | 91 > > +++++++++++++++++++++++++++++++++++++++++++--- > > > libavfilter/allfilters.c | 1 > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f > > 0001-avfilter-add-adesurge-filter.patch > > > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 2001 > > > From: Paul B Mahol > > > Date: Wed, 9 Aug 2023 18:21:25 +0200 > > > Subject: [PATCH 1/3] avfilter: add adesurge filter > > > > > > Signed-off-by: Paul B Mahol > > > --- > > > doc/filters.texi | 51 ++++++++++++++++++++++ > > > libavfilter/Makefile | 1 + > > > libavfilter/af_adeclick.c | 91 +++++++++++++++++++++++++++++++++++++= -- > > > libavfilter/allfilters.c | 1 + > > > 4 files changed, 140 insertions(+), 4 deletions(-) > > > > It seems you forgot adding fate tests, please make sure fate tests are > > added > > when this or a future variant is applied > > >=20 > Sorry, Sir!, >=20 > The filter modules are not mention for fate testing, doc/developer.texi: 807 @item 808 Consider adding a regression test for your code. All new modules 809 should be covered by tests. That includes demuxers, muxers, decoders, = encoders 810 filters, bitstream filters, parsers. If its not possible to do that, a= dd 811 an explanation why to your patchset, its ok to not test if theres a re= ason. so yes, filters should be tested too > and for obvious > reasons like usage of non-integer math. A wide range of non integer modules are tested. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. --sJ8IagDoaaxT4KYQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNT+gQAKCRBhHseHBAsP qzpNAJ9mHSGqOxX/l+5wFM4r8DsTZoTzawCfSiqJs/WG1Hi3QoNiB/be4HJRqyQ= =pAVQ -----END PGP SIGNATURE----- --sJ8IagDoaaxT4KYQ-- --===============3415498571154342532== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3415498571154342532==--