On Wed, Aug 09, 2023 at 11:36:16PM +0200, Paul B Mahol wrote: > Patches attached. > af_adeclick.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > b19bd0c3f05d5ebce92f7500dab61bd85d9b3661 0003-avfilter-af_adeclick-do-not-output-pointless-message.patch > From 2d8c330f543397642fa1afe0a01a67155008d4e1 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 21:53:04 +0200 > Subject: [PATCH 3/3] avfilter/af_adeclick: do not output pointless message > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_adeclick.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) [...] > af_adeclick.c | 136 ++++++++++++++++++++++++++++------------------------------ > 1 file changed, 67 insertions(+), 69 deletions(-) > cfc7bc440f2f408f8570501f3afb2de235860221 0002-avfilter-af_adeclick-refactor-and-cleanup.patch > From 0a6de9b1482ece4402b1c7274501b43e43f5f56a Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 21:49:19 +0200 > Subject: [PATCH 2/3] avfilter/af_adeclick: refactor and cleanup > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_adeclick.c | 136 +++++++++++++++++++------------------- > 1 file changed, 67 insertions(+), 69 deletions(-) [...] > doc/filters.texi | 51 +++++++++++++++++++++++++ > libavfilter/Makefile | 1 > libavfilter/af_adeclick.c | 91 +++++++++++++++++++++++++++++++++++++++++++--- > libavfilter/allfilters.c | 1 > 4 files changed, 140 insertions(+), 4 deletions(-) > 61d03514ba9fa85d1ec308ce37037a0c07ad9a7f 0001-avfilter-add-adesurge-filter.patch > From af565f57f733af327edc1e1724e31a3c5f1fe44f Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Wed, 9 Aug 2023 18:21:25 +0200 > Subject: [PATCH 1/3] avfilter: add adesurge filter > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 51 ++++++++++++++++++++++ > libavfilter/Makefile | 1 + > libavfilter/af_adeclick.c | 91 +++++++++++++++++++++++++++++++++++++-- > libavfilter/allfilters.c | 1 + > 4 files changed, 140 insertions(+), 4 deletions(-) It seems you forgot adding fate tests, please make sure fate tests are added when this or a future variant is applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better.