From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1022F46D97 for ; Thu, 10 Aug 2023 09:34:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1817568C8B4; Thu, 10 Aug 2023 12:34:10 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA6C168C7E2 for ; Thu, 10 Aug 2023 12:34:03 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 14270E0008 for ; Thu, 10 Aug 2023 09:34:02 +0000 (UTC) Date: Thu, 10 Aug 2023 11:34:02 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230810093402.GB7802@pb2> References: <20230809183407.29554-1-michael@niedermayer.cc> <20230809193030.GA7802@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5900891514312875043==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5900891514312875043== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ct7O0SBSsfHCgafd" Content-Disposition: inline --Ct7O0SBSsfHCgafd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote: > On Wed, Aug 9, 2023 at 9:30=E2=80=AFPM Michael Niedermayer > wrote: >=20 > > Hi Paul > > > > On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote: > > > This is not correct, and please stop writing such patches. Thanks. > > > > If there is a problem in the bugfix, please explain what the problem is. > > If you do not like the specific fix, you can fix it differently too or > > tell me what you prefer. > > Simply saying "no" with no explanation repeatedly is rude > > >=20 > Patch breaks valid files. Does the patch break files you create intentionally or files pre-existing ? The check can fail if 2 data segments overlap, one can craft a file with that. The previous patches are implemented differently and dont have that behavior, you rejected them too and at the time you did call them "hacky" and did not mention that they break anything and also ignored all further questions I just implemented this one differently as the other way was rejected by you with no comment Also please provide the files this breaks so the issue can be fixed thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --Ct7O0SBSsfHCgafd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNSvBgAKCRBhHseHBAsP q2D/AJ9gLGSYG+uBJ8TxvVxmJnmmMM6zzwCbB1KGeuUAa3Nmynn1HCNGbR7CGF4= =o57t -----END PGP SIGNATURE----- --Ct7O0SBSsfHCgafd-- --===============5900891514312875043== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5900891514312875043==--