Re: [FFmpeg-devel] [PATCH v2] avcodec/mv30: Check the input length before allocation

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1406 bytes --]

On Wed, Aug 09, 2023 at 11:20:43PM +0200, Paul B Mahol wrote:
> On Wed, Aug 9, 2023 at 9:30 PM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > Hi Paul
> >
> > On Wed, Aug 09, 2023 at 08:53:03PM +0200, Paul B Mahol wrote:
> > > This is not correct, and please stop writing such patches. Thanks.
> >
> > If there is a problem in the bugfix, please explain what the problem is.
> > If you do not like the specific fix, you can fix it differently too or
> > tell me what you prefer.
> > Simply saying "no" with no explanation repeatedly is rude
> >
> 
> Patch breaks valid files.

Does the patch break files you create intentionally or files
pre-existing ?
The check can fail if 2 data segments overlap, one can craft
a file with that. The previous patches are implemented differently
and dont have that behavior, you rejected them too and at the time
you did call them "hacky" and did not mention that they break anything
and also ignored all further questions

I just implemented this one differently as the other way was rejected
by you with no comment

Also please provide the files this breaks so the issue can be
fixed

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".