From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D58246C06 for ; Mon, 7 Aug 2023 00:53:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F72F68C76F; Mon, 7 Aug 2023 03:53:30 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7935068C4FC for ; Mon, 7 Aug 2023 03:53:24 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DEBF8FF803 for ; Mon, 7 Aug 2023 00:53:23 +0000 (UTC) Date: Mon, 7 Aug 2023 02:53:23 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230807005323.GW7802@pb2> References: <20230807004917.31578-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20230807004917.31578-1-michael@niedermayer.cc> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4364820042745727274==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4364820042745727274== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xh9GJMgkD8Kj4g3J" Content-Disposition: inline --xh9GJMgkD8Kj4g3J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 07, 2023 at 02:49:03AM +0200, Michael Niedermayer wrote: > From: Andreas Rheinhardt >=20 > Don't include them implicitly via avcodec.h. This avoids > indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c, > and lavf/rtp(dec|enc)_vc2hq.c. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/dirac.c | 3 +++ > libavcodec/dirac.h | 6 +++++- > 2 files changed, 8 insertions(+), 1 deletion(-) This was mistakely sent i fat fingered a 1 between -5 so it was -15 of git send-email i couldnt kill the send-mail quickly enough to stop the first mail sorry [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --xh9GJMgkD8Kj4g3J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZNBAfwAKCRBhHseHBAsP q5n2AJ9z71dx3wxBawwnbPlLW9ojH7fGhACfeKPujZtHqqwKBTEe3FQuqIWShg4= =b3Et -----END PGP SIGNATURE----- --xh9GJMgkD8Kj4g3J-- --===============4364820042745727274== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4364820042745727274==--