[FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly

[FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly

[Michael Niedermayer]

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>

Don't include them implicitly via avcodec.h. This avoids
indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c,
and lavf/rtp(dec|enc)_vc2hq.c.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/dirac.c | 3 +++
 libavcodec/dirac.h | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c
index bc51a2fbd7..4736304977 100644
--- a/libavcodec/dirac.c
+++ b/libavcodec/dirac.c
@@ -26,9 +26,12 @@
  * @author Marco Gerards <marco@gnu.org>, David Conrad, Jordi Ortiz <nenjordi@gmail.com>
  */
 
+#include "config.h"
+
 #include "libavutil/pixdesc.h"
 
 #include "dirac.h"
+#include "get_bits.h"
 #include "golomb.h"
 #include "mpeg12data.h"
 
diff --git a/libavcodec/dirac.h b/libavcodec/dirac.h
index e6d9d346d9..8c348cdc02 100644
--- a/libavcodec/dirac.h
+++ b/libavcodec/dirac.h
@@ -31,7 +31,11 @@
  * @author Jordi Ortiz
  */
 
-#include "avcodec.h"
+#include <stddef.h>
+#include <stdint.h>
+
+#include "libavutil/pixfmt.h"
+#include "libavutil/rational.h"
 
 /**
  * The spec limits the number of wavelet decompositions to 4 for both
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/15] avcodec/dirac: Include used headers directly

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]

On Mon, Aug 07, 2023 at 02:49:03AM +0200, Michael Niedermayer wrote:
> From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> 
> Don't include them implicitly via avcodec.h. This avoids
> indirect avcodec.h inclusions in lavc/dirac.c, lavf/oggparsedirac.c,
> and lavf/rtp(dec|enc)_vc2hq.c.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/dirac.c | 3 +++
>  libavcodec/dirac.h | 6 +++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)

This was mistakely sent
i fat fingered a 1 between -5 so it was -15 of git send-email
i couldnt kill the send-mail quickly enough to stop the first mail

sorry

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".