From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 1/5] avcodec/mv30: Allocate frame later
Date: Mon, 7 Aug 2023 02:49:45 +0200
Message-ID: <20230807004949.31634-1-michael@niedermayer.cc> (raw)
This way we can check the input before allocation in the next commit
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/mv30.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
index c2d0547053..0b19534b00 100644
--- a/libavcodec/mv30.c
+++ b/libavcodec/mv30.c
@@ -414,6 +414,9 @@ static int decode_intra(AVCodecContext *avctx, GetBitContext *gb, AVFrame *frame
skip_bits_long(gb, s->mode_size * 8);
+ if ((ret = ff_get_buffer(avctx, frame, AV_GET_BUFFER_FLAG_REF)) < 0)
+ return ret;
+
linesize[0] = frame->linesize[0];
linesize[1] = frame->linesize[0];
linesize[2] = frame->linesize[0];
@@ -473,6 +476,9 @@ static int decode_inter(AVCodecContext *avctx, GetBitContext *gb,
int ret, cnt = 0;
int flags = 0;
+ if ((ret = ff_get_buffer(avctx, frame, AV_GET_BUFFER_FLAG_REF)) < 0)
+ return ret;
+
in_linesize[0] = prev->linesize[0];
in_linesize[1] = prev->linesize[0];
in_linesize[2] = prev->linesize[0];
@@ -610,9 +616,6 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
if ((ret = init_get_bits8(gb, avpkt->data, avpkt->size)) < 0)
return ret;
- if ((ret = ff_get_buffer(avctx, frame, AV_GET_BUFFER_FLAG_REF)) < 0)
- return ret;
-
s->intra_quant = get_bits(gb, 8);
s->inter_quant = s->intra_quant + get_sbits(gb, 8);
s->is_inter = get_bits_le(gb, 16);
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-08-07 0:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 0:49 Michael Niedermayer [this message]
2023-08-07 0:49 ` [FFmpeg-devel] [PATCH 2/5] avcodec/mv30: Check the input length before allocation Michael Niedermayer
2023-08-07 8:22 ` Paul B Mahol
2023-09-22 19:27 ` Michael Niedermayer
2023-09-22 19:31 ` Paul B Mahol
2023-09-22 21:34 ` Michael Niedermayer
2023-09-22 21:57 ` Paul B Mahol
2023-08-07 0:49 ` [FFmpeg-devel] [PATCH 3/5] avcodec/xvididct: Fix integer overflow in idct_row() Michael Niedermayer
2023-08-23 20:42 ` Michael Niedermayer
2023-08-07 0:49 ` [FFmpeg-devel] [PATCH 4/5] avcodec/wavarc: Check shift Michael Niedermayer
2023-08-07 0:49 ` [FFmpeg-devel] [PATCH 5/5] avcodec/wavarc: Check that nb_samples is not negative Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807004949.31634-1-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git