Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT transforms
Date: Thu, 3 Aug 2023 22:32:53 +0200
Message-ID: <20230803203253.GP7802@pb2> (raw)
In-Reply-To: <NawD9Lq--3-9@lynne.ee>

[-- Attachment #1.1: Type: text/plain, Size: 2585 bytes --]

On Thu, Aug 03, 2023 at 06:26:16PM +0200, Lynne wrote:
> These are in-place transforms, required for DCT-I and DST-I.
> 
> Templated as the mod2 variant requires minor modifications, and is
> required specifically for DCT-I/DST-I.
> 
> Quite optimized, as there's no need for any additional buffer storage.
> 

>  doc/APIchanges          |    3 
>  libavutil/tx.c          |   18 ++++
>  libavutil/tx.h          |   10 ++
>  libavutil/tx_template.c |  175 +++++++++++++++++++++++++++++++++++++-----------
>  libavutil/version.h     |    2 
>  5 files changed, 167 insertions(+), 41 deletions(-)
> 6e6308365cd78a84c7db5800207e6b5977945079  0001-lavu-tx-add-real-to-real-and-real-to-imaginary-RDFT-.patch
> From 2ea5e2541c2551bf1b56e967d35946289a85aa49 Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Thu, 3 Aug 2023 18:21:23 +0200
> Subject: [PATCH 1/2] lavu/tx: add real to real and real to imaginary RDFT
>  transforms
> 
> These are in-place transforms, required for DCT-I and DST-I.
> 
> Templated as the mod2 variant requires minor modifications, and is
> required specifically for DCT-I/DST-I.

not sure if i forgot some patch but
this seems to break fate-binkaudio-dct

make V=2 fate-binkaudio-dct -j32
...
[bink @ 0x559fc8d8dcc0] Failed to open codec in avformat_find_stream_info
[bink @ 0x559fc8d8dcc0] Packet corrupt (stream = 0, dts = NOPTS).
[bink @ 0x559fc8d8dcc0] Failed to open codec in avformat_find_stream_info
[bink @ 0x559fc8d8dcc0] Could not find codec parameters for stream 1 (Audio: binkaudio_dct, 44000 Hz, 0 channels, fltp): unspecified number of channels
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
Input #0, bink, from 'fate/fate-suite//bink/binkaudio_dct.bik':
  Duration: 00:00:08.87, start: 0.000000, bitrate: 183 kb/s
  Stream #0:0[0x0]: Video: binkvideo (BIKi / 0x694B4942), yuv420p(tv), 640x480, 30 fps, 30 tbr, 30 tbn
  Stream #0:1[0x0]: Audio: binkaudio_dct, 44000 Hz, stereo, fltp
[aist#0:1/binkaudio_dct @ 0x559fc8d93080] Error while opening decoder: Function not implemented
[aost#0:0/pcm_s16le @ 0x559fc8de5c40] Error initializing a simple filtergraph
Error opening output file -.
Error opening output files: Function not implemented
threads=1
tests/Makefile:308: recipe for target 'fate-binkaudio-dct' failed
make: *** [fate-binkaudio-dct] Error 218

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".