From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9B477403D6 for ; Thu, 3 Aug 2023 15:36:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9809F68C6A2; Thu, 3 Aug 2023 18:36:37 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F1B3868BFBC for ; Thu, 3 Aug 2023 18:36:30 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 172C920008 for ; Thu, 3 Aug 2023 15:36:29 +0000 (UTC) Date: Thu, 3 Aug 2023 17:36:29 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230803153629.GL7802@pb2> References: <20230802000135.26482-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0999084918880290495==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0999084918880290495== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oygaTt13GzoPPEjZ" Content-Disposition: inline --oygaTt13GzoPPEjZ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas H=E4rdin wrote: > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > Fixes: freeing of uninitialized pointers > > Fixes: part of 58299 > >=20 > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > =A0libavcodec/jpeg2000htdec.c | 4 ++-- > > =A01 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c > > index 4c4e54710d..2b082b3b2f 100644 > > --- a/libavcodec/jpeg2000htdec.c > > +++ b/libavcodec/jpeg2000htdec.c > > @@ -1174,8 +1174,8 @@ ff_jpeg2000_decode_htj2k(const > > Jpeg2000DecoderContext *s, Jpeg2000CodingStyle *c > > =A0=A0=A0=A0 int ret; > > =A0 > > =A0=A0=A0=A0 /* Temporary buffers */ > > -=A0=A0=A0 int32_t *sample_buf; > > -=A0=A0=A0 uint8_t *block_states; > > +=A0=A0=A0 int32_t *sample_buf =3D NULL; > > +=A0=A0=A0 uint8_t *block_states =3D NULL; >=20 > Looks OK will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire --oygaTt13GzoPPEjZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZMvJeQAKCRBhHseHBAsP qzN6AKCA16njI0OnLWu54HY7xi0kH8e3SACffBtpzq7a8YFFlRQKRg1xYMxoUEc= =qfoE -----END PGP SIGNATURE----- --oygaTt13GzoPPEjZ-- --===============0999084918880290495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0999084918880290495==--