From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 90AEF46A44 for ; Wed, 2 Aug 2023 12:14:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E314768BE95; Wed, 2 Aug 2023 15:14:21 +0300 (EEST) Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8562F6802C1 for ; Wed, 2 Aug 2023 15:14:15 +0300 (EEST) Received: from madara.intra.ispras.ru (unknown [10.10.34.59]) by mail.ispras.ru (Postfix) with ESMTPSA id A966940F1DE3; Wed, 2 Aug 2023 12:14:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru A966940F1DE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1690978454; bh=TEaDgSO9qDJHAt25HguNpI0YnVfxqp8OhxhV6Lw5wqg=; h=From:To:Cc:Subject:Date:From; b=qZE7cPgMixhBsuUB4qZQD5MpreBb9r7PH6q9sBnP6KZrJxCU6rOMG+MyZQeDqx4Ru 6xIKCZXtRETaWkM5j97/UAX6qU3Bxyb26dmPg+jwqXPw/WPVJRthbCxmoV+JDS4PWy XLdgrH/SS2MeeG4xhoZeKEiwcSMNG4th5tVmonHI= From: kobrineli To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Aug 2023 15:14:10 +0300 Message-Id: <20230802121410.1141794-1-kobrineli@ispras.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 libswresample: Prevent out of bounds Subject: [FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Eli Kobrin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Eli Kobrin We've been fuzzing torchvision with [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) and found out of bounds error in ffmpeg project at audioconvert.c:151. To prevent error we need to fix checks for in and out fmt in swr_init. Signed-off-by: Eli Kobrin --- libswresample/swresample.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswresample/swresample.c b/libswresample/swresample.c index 6dc329a9d0..fb3d7bccbf 100644 --- a/libswresample/swresample.c +++ b/libswresample/swresample.c @@ -196,11 +196,11 @@ av_cold int swr_init(struct SwrContext *s){ clear_context(s); - if(s-> in_sample_fmt >= AV_SAMPLE_FMT_NB){ + if((unsigned) s-> in_sample_fmt >= AV_SAMPLE_FMT_NB){ av_log(s, AV_LOG_ERROR, "Requested input sample format %d is invalid\n", s->in_sample_fmt); return AVERROR(EINVAL); } - if(s->out_sample_fmt >= AV_SAMPLE_FMT_NB){ + if((unsigned) s->out_sample_fmt >= AV_SAMPLE_FMT_NB){ av_log(s, AV_LOG_ERROR, "Requested output sample format %d is invalid\n", s->out_sample_fmt); return AVERROR(EINVAL); } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".