From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 57259466EE for ; Wed, 2 Aug 2023 05:32:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 875A268C536; Wed, 2 Aug 2023 08:32:36 +0300 (EEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E96B68BF8D for ; Wed, 2 Aug 2023 08:32:30 +0300 (EEST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-51d95aed33aso8451119a12.3 for ; Tue, 01 Aug 2023 22:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690954349; x=1691559149; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=iJll/9mq1H9vgaNfTxHs9o+9UwL9pP/aWDODhCEMAZk=; b=ZsIVXz/RbJp9cX+vKZ7T4lvOjnyyuhv7GdMPxYi6HZkAdUobU75yEiR78p7Uof5ezb X6ITZFouW8R8CmRE/IrvjB+StqFe2+4YyUr4XTskRBT5J2Y3PMYf04xadzpYpgQQeIkT WwmmBML25r1maYeAmSy8QCsi6qFzvxc/7FCjVTYrWDMzt8HnoNZlxW3iuvW3snNa93M4 Aq5l3z8cCFntv0Qq9NlTmeaXLaEeWis6/Fi1VSoXZuHE2KqgZ0VyGXw0O3S19nJSyTCJ A8iMScA2Wtp3Gai0A4fI4iaUAx8ASE2aDpyVSNiKopcwi2chsQCd/MXbN5a/R0rxh6hm DK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690954349; x=1691559149; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iJll/9mq1H9vgaNfTxHs9o+9UwL9pP/aWDODhCEMAZk=; b=Zc7t4A3YkqevGIhxMrIoJNbNPgfwfQnRHWtYFDJY/TZy+uci7tCh2KwT+cz/dFW+wJ b0kqO91p3UfYHDG1XSF7jzV7yvckENxdplYA2SIY8rvaiVdzJXIQtWRpoWdQcjQfQ8xx iPIWNQHhzS24GRnwc9RYWajE3ESM5QMgflV9JK3gA4UR+y4HKdZ/RXQ8zmJ/9KwrFAHU dkirZ1D8EXcLu+7WT0c+rLi+FMBzjBsztmZSUrw8c9rq8N6t6In8s3SirCOScjlCQMr3 NhWGUgCiIdod/XIKelGY1hINV+OJALRZtSs5iV9zD9O8dcPFhS4FJt7nmXiwklV2WuLr UTng== X-Gm-Message-State: ABy/qLZ9FRVmeIwcXVO4INX8v6bRo3hPKjQN7QFPtAP532RFc5jf7mOl QWzGb5gacwMC6ddf1O1eqiHH99gmhLU= X-Google-Smtp-Source: APBJJlEU/FzmKPOynE57ox4fBqOWkwMVi3KXV1On23h4Ze8VCOoWT5CPKNLjVXAnYTQbP6dCaZ0jVQ== X-Received: by 2002:aa7:d892:0:b0:521:e544:f3 with SMTP id u18-20020aa7d892000000b00521e54400f3mr3366191edq.41.1690954348842; Tue, 01 Aug 2023 22:32:28 -0700 (PDT) Received: from mariano ([82.84.192.32]) by smtp.gmail.com with ESMTPSA id n10-20020aa7c44a000000b0052238bc70ccsm7905211edr.89.2023.08.01.22.32.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 22:32:28 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 70868BFB73; Wed, 2 Aug 2023 07:32:28 +0200 (CEST) Date: Wed, 2 Aug 2023 07:32:28 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230802053228.GF10927@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230715104611.17902-1-anton@khirnov.net> <20230715104611.17902-46-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230715104611.17902-46-anton@khirnov.net> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Saturday 2023-07-15 12:46:10 +0200, Anton Khirnov wrote: > Inline the relevant part of ffprobe_cleanup() into main() and drop the > rest. > --- > fftools/ffprobe.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index e234c92904..a39185f6fe 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -381,17 +381,6 @@ static void log_callback(void *ptr, int level, const char *fmt, va_list vl) > #endif > } > > -static void ffprobe_cleanup(int ret) > -{ > - int i; > - for (i = 0; i < FF_ARRAY_ELEMS(sections); i++) > - av_dict_free(&(sections[i].entries_to_show)); > - Was this part discarded? This is mostly needed to avoid valgrind warnings. LGTM otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".