From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 691CC466EE for ; Wed, 2 Aug 2023 05:13:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 99EF168C24A; Wed, 2 Aug 2023 08:13:25 +0300 (EEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BFC168C041 for ; Wed, 2 Aug 2023 08:13:18 +0300 (EEST) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-9891c73e0fbso110765566b.1 for ; Tue, 01 Aug 2023 22:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690953197; x=1691557997; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=HpB3GLsmMCg8ab6xQoPbRreDm2wR+aK8oB8zb2qz2pI=; b=m5FQh0xzYGs6h8+W/jVQ7+z3rP4GHFYuXcN+k/VYRfgMnz5bT+Fnrc9lTVGIzSzaD7 9OTc6C19oDSW0klVCHGMO5TbiyCQ/rfPDhBjoD955cfY6UPKY6wXVEDIUpnydPiQVJqO Gu0OtW7OuN5GJXRiVmLzmK7Jup2bvDE3m12PYItPb+UBQdsRSSZwLaBcYLreF4sW7I4f gCOuG4wEpLpnnTk76nT3oz8oXUPNIQ8I0TQtqgXqKzWwbcURefxBa+aQa9+cgl4lTfEL 0cUdZkbA7LAPKv+U9tiD0zh0zdXA/eNigSMzVOmSC3gi4QuhDhHJhB8i8mZQqkblh47x 5uFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690953197; x=1691557997; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HpB3GLsmMCg8ab6xQoPbRreDm2wR+aK8oB8zb2qz2pI=; b=hAHLEMQw/s0aIIlbnZKM+Dlw2Vyd8p0dYH2LlafiddGAIpZnlPoNgvCF05wZK2rdE5 sTAiXYRS/fbrTdIvqcaE/9+pEuJ/MlBe/O/+X3HAYQVwvbqirUb7kKeV+Xz8Dqmt/VWx rzT0XkYjOZh+XmwiQ4nA6v8c8OiRgFMDj8/yVzZzLsIDZIW+s5zqaVNeaVsl+UXnZaUL 2fGhcG8FL8tGl7sFwZvyygqs4+sapsEAztptjY0rmcfmkAWt/pxUWGZGB1OxDaTzWEtB yFkL4XFj/6MvrJ8Vkz2LqkmBJGasyHSkGM4ZEJCa1tv/91wJOGbZQzYkyD+jkSQkKQpy iRvw== X-Gm-Message-State: ABy/qLaS05AM8UhYTm1xl6dnQZMFjuiioLDOd9DLl8d9Chsq84tT2GR6 IGhPYPAJN+pUsM9wIahJaPZMT+Mulps= X-Google-Smtp-Source: APBJJlGqeHtQLwDMC5Xa/axjAZ+6b9RwxTKC47K6o92JHqKxGbQOR5Fp2TBC01t+jZMK5+jxBd635w== X-Received: by 2002:a17:906:9be6:b0:992:2f67:cd34 with SMTP id de38-20020a1709069be600b009922f67cd34mr5663682ejc.22.1690953196802; Tue, 01 Aug 2023 22:13:16 -0700 (PDT) Received: from mariano ([82.84.192.32]) by smtp.gmail.com with ESMTPSA id gr16-20020a170906e2d000b00977cad140a8sm8507993ejb.218.2023.08.01.22.13.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 22:13:15 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 8B1CFBFB73; Wed, 2 Aug 2023 07:13:03 +0200 (CEST) Date: Wed, 2 Aug 2023 07:13:03 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230802051303.GD10927@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffprobe: Fix memleak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Monday 2023-07-31 13:08:37 +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1524491. > Regression since e6126abc6997058ca49ee596b70611bbe367163e. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 81610c097b..5c2d4cbff1 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -2929,8 +2929,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile, > FrameData *fd; > > pkt->opaque_ref = av_buffer_allocz(sizeof(*fd)); > - if (!pkt->opaque_ref) > - return AVERROR(ENOMEM); > + if (!pkt->opaque_ref) { > + ret = AVERROR(ENOMEM); > + goto end; > + } > fd = (FrameData*)pkt->opaque_ref->data; > fd->pkt_pos = pkt->pos; > fd->pkt_size = pkt->size; LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".