Re: [FFmpeg-devel] [PATCH v6 4/5] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1356 bytes --]

On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote:
> This prevents code duplication in the source form by calling the parse
> code that was moved to avcodec last commit. The code will be duplicated
> in binary form for shared builds (it's not that large), but for source
> code it will only exist in one location now.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  libavformat/Makefile          |   6 +-
>  libavformat/img2dec.c         |   4 +-
>  libavformat/jpegxl_anim_dec.c | 132 +++--------
>  libavformat/jpegxl_probe.c    | 412 ----------------------------------
>  libavformat/jpegxl_probe.h    |  37 ---
>  libavformat/version.h         |   2 +-
>  6 files changed, 38 insertions(+), 555 deletions(-)
>  delete mode 100644 libavformat/jpegxl_probe.c
>  delete mode 100644 libavformat/jpegxl_probe.h

breaks build with shared libs

GEN	libavformat/libavformat.ver
LD	libavformat/libavformat.so.60
clang: error: no such file or directory: 'libavformat/jpegxl_parse.o'
src/ffbuild/library.mak:118: recipe for target 'libavformat/libavformat.so.60' failed
make: *** [libavformat/libavformat.so.60] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".