From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EA7E04556B for ; Thu, 27 Jul 2023 20:15:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F115168C540; Thu, 27 Jul 2023 23:15:51 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4653B68C996 for ; Thu, 27 Jul 2023 23:15:45 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9F61C1C0005 for ; Thu, 27 Jul 2023 20:15:44 +0000 (UTC) Date: Thu, 27 Jul 2023 22:15:43 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230727201543.GA7802@pb2> References: <20230727181552.13387-1-Reimar.Doeffinger@gmx.de> MIME-Version: 1.0 In-Reply-To: <20230727181552.13387-1-Reimar.Doeffinger@gmx.de> X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] [RFC] tools/patcheck: portability fixes. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4942948733323989065==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4942948733323989065== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x+bne1ZFwxW5PfJO" Content-Disposition: inline --x+bne1ZFwxW5PfJO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 08:15:52PM +0200, Reimar.Doeffinger@gmx.de wrote: > From: Reimar D=F6ffinger >=20 > Enough to make it run on macOS. > In particular: > - fix "empty subexpression" errors caused by constructs like (smth|), > use ? instead to make them optional > - no -d option for xargs, use the more standard -0 and use tr to > replace newlines with 0. >=20 > Not sure if these cause issues somewhere else, not even completely > sure they all work, but quick testing suggests they work. > On the other hand I remember issues with '?' where I resorted to {0,1} > instead, but I do not remember details. > Ignore if fixing these seems not worth the risk. > --- > tools/patcheck | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) making it work on more platforms is a good idea. It seems still working here on ubuntu but i certainly dont know which syntax constructs work where [...] thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus --x+bne1ZFwxW5PfJO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZMLQbwAKCRBhHseHBAsP q1G9AKCOqCqU8QcaPHZ6fi5oXP2GrafC1ACeKSZFmbFhc9omywfNjwsXyMdYjCw= =fosS -----END PGP SIGNATURE----- --x+bne1ZFwxW5PfJO-- --===============4942948733323989065== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4942948733323989065==--