From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9200447107 for ; Thu, 27 Jul 2023 17:38:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D30C68CA65; Thu, 27 Jul 2023 20:38:45 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F2DBE68C835 for ; Thu, 27 Jul 2023 20:38:38 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 25125E000A for ; Thu, 27 Jul 2023 17:38:37 +0000 (UTC) Date: Thu, 27 Jul 2023 19:38:37 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230727173837.GY7802@pb2> References: <20230726235916.30058-1-michael@niedermayer.cc> <20230726235916.30058-4-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/evc_ps: Check num_ref_pic_list_in_sps X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6933813504277881908==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6933813504277881908== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="utG8zEvBNE7w4yrA" Content-Disposition: inline --utG8zEvBNE7w4yrA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 26, 2023 at 09:19:10PM -0300, James Almer wrote: > On 7/26/2023 8:59 PM, Michael Niedermayer wrote: > > Fixes: out of array write > > Fixes: 60798/clusterfuzz-testcase-minimized-ffmpeg_BSF_EVC_FRAME_MERGE_= fuzzer-4633529766772736 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/evc_ps.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > >=20 > > diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c > > index 04ee6a45e6..64384a392c 100644 > > --- a/libavcodec/evc_ps.c > > +++ b/libavcodec/evc_ps.c > > @@ -243,11 +243,20 @@ int ff_evc_parse_sps(GetBitContext *gb, EVCParamS= ets *ps) > > sps->rpl1_same_as_rpl0_flag =3D get_bits1(gb); > > sps->num_ref_pic_list_in_sps[0] =3D get_ue_golomb(gb); > > + if ((unsigned)sps->num_ref_pic_list_in_sps[0] >=3D EVC_MAX_NUM= _RPLS) { >=20 > EVC_MAX_NUM_RPLS should be 64, not 32 as it's currently defined. So change > that too and it LGTM. ok will do thx for reviewing [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --utG8zEvBNE7w4yrA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZMKrjAAKCRBhHseHBAsP qzToAJ92Oa9epOCOpxyCupfN0D6d+1Q/RwCeN5AjNyW9x0CGZDC10nyeIiq51aQ= =kFL/ -----END PGP SIGNATURE----- --utG8zEvBNE7w4yrA-- --===============6933813504277881908== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6933813504277881908==--