From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5105547073 for ; Tue, 25 Jul 2023 23:17:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE6F368C85F; Wed, 26 Jul 2023 02:17:47 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D9F468C812 for ; Wed, 26 Jul 2023 02:17:41 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 11E441C0003 for ; Tue, 25 Jul 2023 23:17:39 +0000 (UTC) Date: Wed, 26 Jul 2023 01:17:39 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230725231739.GV7802@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/avfft: deprecate the API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5438358254771050801==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5438358254771050801== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X6f5cqjOqKjuoPgI" Content-Disposition: inline --X6f5cqjOqKjuoPgI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 25, 2023 at 12:47:12AM +0200, Lynne wrote: > Jul 25, 2023, 00:19 by andreas.rheinhardt@outlook.com: >=20 > > Lynne: > > > >> Subject: [PATCH 2/2] lavc/avfft: deprecate the API > >> > >> This deprecates the currently unused API. > >> > > ^ > > superseded > > > >> --- > >> doc/APIchanges | 4 ++++ > >> libavcodec/avfft.h | 25 +++++++++++++++++++++++++ > >> libavcodec/tests/fft.c | 4 ++++ > >> libavcodec/version.h | 2 +- > >> libavcodec/version_major.h | 2 ++ > >> 5 files changed, 36 insertions(+), 1 deletion(-) > >> > >> diff --git a/doc/APIchanges b/doc/APIchanges > >> index 5afe8bcb75..38fc0b1459 100644 > >> --- a/doc/APIchanges > >> +++ b/doc/APIchanges > >> @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2= 023-02-09 > >> =20 > >> API changes, most recent first: > >> =20 > >> +2023-07-xx - xxxxxxxxxx - lavc 60.23.100 - avfft.h > >> + Deprecate av_dct, av_rdft, av_fft and av_mdct. > >> > > > > This should mention that the whole header is deprecated and will be rem= oved. > > > >> + Replaced by libavutil/tx.h > >> + > >> 2023-07-xx - xxxxxxxxxx - lavc 60 - avcodec.h > >> Deprecate AV_CODEC_FLAG_DROPCHANGED without replacement. > >> =20 > >> diff --git a/libavcodec/avfft.h b/libavcodec/avfft.h > >> index 0c0f9b8d8d..6401833089 100644 > >> --- a/libavcodec/avfft.h > >> +++ b/libavcodec/avfft.h > >> @@ -19,6 +19,10 @@ > >> #ifndef AVCODEC_AVFFT_H > >> #define AVCODEC_AVFFT_H > >> =20 > >> +#include "libavutil/attributes.h" > >> +#include "version_major.h" > >> +#if FF_API_AVFFT > >> + > >> /** > >> * @file > >> * @ingroup lavc_fft > >> @@ -44,26 +48,38 @@ typedef struct FFTContext FFTContext; > >> * Set up a complex FFT. > >> * @param nbits log2 of the length of the input array > >> * @param inverse if 0 perform the forward transform, if 1 per= form the inverse > >> + * @deprecated use AVTXContext from libavutil/tx.h > >> */ > >> +attribute_deprecated > >> FFTContext *av_fft_init(int nbits, int inverse); > >> =20 > >> /** > >> * Do the permutation needed BEFORE calling ff_fft_calc(). > >> + * @deprecated use AVTXContext from libavutil/tx.h > >> */ > >> +attribute_deprecated > >> void av_fft_permute(FFTContext *s, FFTComplex *z); > >> =20 > >> /** > >> * Do a complex FFT with the parameters defined in av_fft_init(). The > >> * input data must be permuted before. No 1.0/sqrt(n) normalization is= done. > >> + * @deprecated use AVTXContext from libavutil/tx.h > >> > > > > This deprecation warning is supposed to apply to av_fft_calc() and > > apparently AVTXContext is not a replacement for av_fft_calc(). Probably > > better to write something like: "Use the AVTX API from libavutil/tx.h." > > >=20 > v2 attached. Added a comment to both APIchanges > on a replacement, and added comments to this file to > indicate how to replace each functionality. >=20 >=20 > >> =20 > >> -#define LIBAVCODEC_VERSION_MINOR 22 > >> +#define LIBAVCODEC_VERSION_MINOR 23 > >> #define LIBAVCODEC_VERSION_MICRO 100 > >> =20 > >> #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJ= OR, \ > >> diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h > >> index 95c5aec0c5..cfd0b5023e 100644 > >> --- a/libavcodec/version_major.h > >> +++ b/libavcodec/version_major.h > >> @@ -50,6 +50,8 @@ > >> #define FF_API_TICKS_PER_FRAME (LIBAVCODEC_VERSION_MAJOR < 61) > >> #define FF_API_DROPCHANGED (LIBAVCODEC_VERSION_MAJOR < 61) > >> =20 > >> +#define FF_API_AVFFT (LIBAVCODEC_VERSION_MAJOR < 62) > >> + > >> // reminder to remove CrystalHD decoders on next major bump > >> #define FF_CODEC_CRYSTAL_HD (LIBAVCODEC_VERSION_MAJOR < 61) > >> > > > > This patch is very much orthogonal to my patch (as expected). > > >=20 > This patch is - but my next series of patches will enable full removal of > all FFT code from lavc - which I would prefer to do all at once, if possi= ble. >=20 >=20 > doc/APIchanges | 5 +++++ > libavcodec/avfft.h | 31 +++++++++++++++++++++++++++++++ > libavcodec/tests/fft.c | 4 ++++ > libavcodec/version.h | 2 +- > libavcodec/version_major.h | 2 ++ > 5 files changed, 43 insertions(+), 1 deletion(-) > 601e82db992b2dbebc61b09f460d703c488aa228 v2-0002-lavc-avfft-deprecate-th= e-API.patch > From fc7891b0cfeb296525919d1ff8baaa2c0b68bbeb Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Mon, 24 Jul 2023 23:55:55 +0200 > Subject: [PATCH v2 2/2] lavc/avfft: deprecate the API >=20 > This deprecates the currently unused API. > --- > doc/APIchanges | 5 +++++ > libavcodec/avfft.h | 31 +++++++++++++++++++++++++++++++ > libavcodec/tests/fft.c | 4 ++++ > libavcodec/version.h | 2 +- > libavcodec/version_major.h | 2 ++ > 5 files changed, 43 insertions(+), 1 deletion(-) not sure i missed a patch but this breaks "make testprogs" here CC libavcodec/tests/avfft.o In file included from /usr/include/math.h:37:0, from libavcodec/tests/fft.c:34, from libavcodec/tests/avfft.c:25: /usr/include/x86_64-linux-gnu/bits/types.h:30:1: error: expected =E2=80=98= =3D=E2=80=99, =E2=80=98,=E2=80=99, =E2=80=98;=E2=80=99, =E2=80=98asm=E2=80= =99 or =E2=80=98__attribute__=E2=80=99 before =E2=80=98typedef=E2=80=99 typedef unsigned char __u_char; ^~~~~~~ thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --X6f5cqjOqKjuoPgI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZMBYDwAKCRBhHseHBAsP qwNUAJ0es8rsr1g3BPeBMPKkX3Yvzpy4CACdGztzZUJloC2liNl/OpqoIf1V6xM= =bK86 -----END PGP SIGNATURE----- --X6f5cqjOqKjuoPgI-- --===============5438358254771050801== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5438358254771050801==--