* [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei
@ 2023-07-25 19:29 Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec: move mastering display colour volume " Jan Ekström
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Jan Ekström @ 2023-07-25 19:29 UTC (permalink / raw)
To: ffmpeg-devel
This allows parsing code to be re-utilized from H.264, as well as probably
from VVC in the future.
This additionally eases verification of the AVCodecContext side data patch
set, which includes libx264 integration for HDR10 side data.
Changes from v1:
* Reordered the new h2645_sei include to correct location as per alphabetical
order. Thanks for Leo Izen for noticing this.
* Cleaned up the mastering_display_metadata.h include in hevcdec, as that file
no longer directly handles AVContentLightMetadata or
AVMasteringDisplayMetadata.
Notes:
* In addition to testing with FATE, looking at the show_frames ffprobe output
for a UHD BD sample with each IRAP containing these SEI entries, the
behavior is the same as before with regards to each frame having the side
data persist.
There is also no change with tests I've done with a UHD BD mp4 remux as well
as an iphone 12 sample I had around, So I think I have not modified the HEVC
behavior in any great manner.
* As for H.264, it now automatically gains support for these SEI messages. It
seems like its definition of CVS (coded video sequence) is from one IDR to
another (essentially a GOP). That said, currently the decoder resets the SEI
setup in decode_nal_units, which means that the side data only persist for
a single frame.
Jan
Jan Ekström (3):
avcodec: move mastering display colour volume SEI handling to
h2645_sei
avcodec: move content light level SEI handling to h2645_sei
avcodec/hevcdec: simplify decrementing of MDCV/CLL flags
libavcodec/h2645_sei.c | 112 +++++++++++++++++++++++++
libavcodec/h2645_sei.h | 16 ++++
libavcodec/h264_slice.c | 2 +
libavcodec/hevc_sei.c | 50 -----------
libavcodec/hevc_sei.h | 16 ----
libavcodec/hevcdec.c | 79 +++--------------
tests/ref/fate/hevc-hdr-vivid-metadata | 6 +-
7 files changed, 143 insertions(+), 138 deletions(-)
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH v2 1/3] avcodec: move mastering display colour volume SEI handling to h2645_sei
2023-07-25 19:29 [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
@ 2023-07-25 19:29 ` Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec: move content light level " Jan Ekström
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jan Ekström @ 2023-07-25 19:29 UTC (permalink / raw)
To: ffmpeg-devel
This allows this common H.274 SEI to be parsed from both H.264
as well as HEVC, as well as probably from VVC in the future.
Generally attempts to keep the original code as similar as possible.
FATE test refererence changes only change the order of side data
export within a single frame. Nothing else seems to have changed.
---
libavcodec/h2645_sei.c | 79 +++++++++++++++++++++++++
libavcodec/h2645_sei.h | 9 +++
libavcodec/h264_slice.c | 1 +
libavcodec/hevc_sei.c | 31 ----------
libavcodec/hevc_sei.h | 9 ---
libavcodec/hevcdec.c | 50 +---------------
tests/ref/fate/hevc-hdr-vivid-metadata | 16 ++---
tests/ref/fate/hevc-hdr10-plus-metadata | 10 ++--
8 files changed, 105 insertions(+), 100 deletions(-)
diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c
index 63ab711bc9..b1ec55d35b 100644
--- a/libavcodec/h2645_sei.c
+++ b/libavcodec/h2645_sei.c
@@ -29,6 +29,7 @@
#include "libavutil/display.h"
#include "libavutil/hdr_dynamic_metadata.h"
#include "libavutil/film_grain_params.h"
+#include "libavutil/mastering_display_metadata.h"
#include "libavutil/pixdesc.h"
#include "libavutil/stereo3d.h"
@@ -392,6 +393,35 @@ static int decode_film_grain_characteristics(H2645SEIFilmGrainCharacteristics *h
return 0;
}
+static int decode_nal_sei_mastering_display_info(H2645SEIMasteringDisplay *s,
+ GetByteContext *gb)
+{
+ int i;
+
+ if (bytestream2_get_bytes_left(gb) < 24)
+ return AVERROR_INVALIDDATA;
+
+ // Mastering primaries
+ for (i = 0; i < 3; i++) {
+ s->display_primaries[i][0] = bytestream2_get_be16u(gb);
+ s->display_primaries[i][1] = bytestream2_get_be16u(gb);
+ }
+ // White point (x, y)
+ s->white_point[0] = bytestream2_get_be16u(gb);
+ s->white_point[1] = bytestream2_get_be16u(gb);
+
+ // Max and min luminance of mastering display
+ s->max_luminance = bytestream2_get_be32u(gb);
+ s->min_luminance = bytestream2_get_be32u(gb);
+
+ // As this SEI message comes before the first frame that references it,
+ // initialize the flag to 2 and decrement on IRAP access unit so it
+ // persists for the coded video sequence (e.g., between two IRAPs)
+ s->present = 2;
+
+ return 0;
+}
+
int ff_h2645_sei_message_decode(H2645SEI *h, enum SEIType type,
enum AVCodecID codec_id, GetBitContext *gb,
GetByteContext *gbyte, void *logctx)
@@ -412,6 +442,9 @@ int ff_h2645_sei_message_decode(H2645SEI *h, enum SEIType type,
case SEI_TYPE_AMBIENT_VIEWING_ENVIRONMENT:
return decode_ambient_viewing_environment(&h->ambient_viewing_environment,
gbyte);
+ case SEI_TYPE_MASTERING_DISPLAY_COLOUR_VOLUME:
+ return decode_nal_sei_mastering_display_info(&h->mastering_display,
+ gbyte);
default:
return FF_H2645_SEI_MESSAGE_UNHANDLED;
}
@@ -652,6 +685,51 @@ int ff_h2645_sei_to_frame(AVFrame *frame, H2645SEI *sei,
dst_env->ambient_light_y = av_make_q(env->ambient_light_y, 50000);
}
+ if (sei->mastering_display.present) {
+ // HEVC uses a g,b,r ordering, which we convert to a more natural r,g,b
+ const int mapping[3] = {2, 0, 1};
+ const int chroma_den = 50000;
+ const int luma_den = 10000;
+ int i;
+ AVMasteringDisplayMetadata *metadata =
+ av_mastering_display_metadata_create_side_data(frame);
+ if (!metadata)
+ return AVERROR(ENOMEM);
+
+ for (i = 0; i < 3; i++) {
+ const int j = mapping[i];
+ metadata->display_primaries[i][0].num = sei->mastering_display.display_primaries[j][0];
+ metadata->display_primaries[i][0].den = chroma_den;
+ metadata->display_primaries[i][1].num = sei->mastering_display.display_primaries[j][1];
+ metadata->display_primaries[i][1].den = chroma_den;
+ }
+ metadata->white_point[0].num = sei->mastering_display.white_point[0];
+ metadata->white_point[0].den = chroma_den;
+ metadata->white_point[1].num = sei->mastering_display.white_point[1];
+ metadata->white_point[1].den = chroma_den;
+
+ metadata->max_luminance.num = sei->mastering_display.max_luminance;
+ metadata->max_luminance.den = luma_den;
+ metadata->min_luminance.num = sei->mastering_display.min_luminance;
+ metadata->min_luminance.den = luma_den;
+ metadata->has_luminance = 1;
+ metadata->has_primaries = 1;
+
+ av_log(avctx, AV_LOG_DEBUG, "Mastering Display Metadata:\n");
+ av_log(avctx, AV_LOG_DEBUG,
+ "r(%5.4f,%5.4f) g(%5.4f,%5.4f) b(%5.4f %5.4f) wp(%5.4f, %5.4f)\n",
+ av_q2d(metadata->display_primaries[0][0]),
+ av_q2d(metadata->display_primaries[0][1]),
+ av_q2d(metadata->display_primaries[1][0]),
+ av_q2d(metadata->display_primaries[1][1]),
+ av_q2d(metadata->display_primaries[2][0]),
+ av_q2d(metadata->display_primaries[2][1]),
+ av_q2d(metadata->white_point[0]), av_q2d(metadata->white_point[1]));
+ av_log(avctx, AV_LOG_DEBUG,
+ "min_luminance=%f, max_luminance=%f\n",
+ av_q2d(metadata->min_luminance), av_q2d(metadata->max_luminance));
+ }
+
return 0;
}
@@ -667,4 +745,5 @@ void ff_h2645_sei_reset(H2645SEI *s)
av_buffer_unref(&s->dynamic_hdr_vivid.info);
s->ambient_viewing_environment.present = 0;
+ s->mastering_display.present = 0;
}
diff --git a/libavcodec/h2645_sei.h b/libavcodec/h2645_sei.h
index e07ae10376..83e1b2ec16 100644
--- a/libavcodec/h2645_sei.h
+++ b/libavcodec/h2645_sei.h
@@ -105,6 +105,14 @@ typedef struct H2645SEIFilmGrainCharacteristics {
int persistence_flag; //< HEVC only
} H2645SEIFilmGrainCharacteristics;
+typedef struct H2645SEIMasteringDisplay {
+ int present;
+ uint16_t display_primaries[3][2];
+ uint16_t white_point[2];
+ uint32_t max_luminance;
+ uint32_t min_luminance;
+} H2645SEIMasteringDisplay;
+
typedef struct H2645SEI {
H2645SEIA53Caption a53_caption;
H2645SEIAFD afd;
@@ -116,6 +124,7 @@ typedef struct H2645SEI {
H2645SEIAlternativeTransfer alternative_transfer;
H2645SEIFilmGrainCharacteristics film_grain_characteristics;
H2645SEIAmbientViewingEnvironment ambient_viewing_environment;
+ H2645SEIMasteringDisplay mastering_display;
} H2645SEI;
enum {
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index 41bf30eefc..586ce20bba 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -439,6 +439,7 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
return ret;
h->sei.common.unregistered.x264_build = h1->sei.common.unregistered.x264_build;
+ h->sei.common.mastering_display = h1->sei.common.mastering_display;
if (!h->cur_pic_ptr)
return 0;
diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index 3c6bde1b62..b7b77d4d0c 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -49,35 +49,6 @@ static int decode_nal_sei_decoded_picture_hash(HEVCSEIPictureHash *s,
return 0;
}
-static int decode_nal_sei_mastering_display_info(HEVCSEIMasteringDisplay *s,
- GetByteContext *gb)
-{
- int i;
-
- if (bytestream2_get_bytes_left(gb) < 24)
- return AVERROR_INVALIDDATA;
-
- // Mastering primaries
- for (i = 0; i < 3; i++) {
- s->display_primaries[i][0] = bytestream2_get_be16u(gb);
- s->display_primaries[i][1] = bytestream2_get_be16u(gb);
- }
- // White point (x, y)
- s->white_point[0] = bytestream2_get_be16u(gb);
- s->white_point[1] = bytestream2_get_be16u(gb);
-
- // Max and min luminance of mastering display
- s->max_luminance = bytestream2_get_be32u(gb);
- s->min_luminance = bytestream2_get_be32u(gb);
-
- // As this SEI message comes before the first frame that references it,
- // initialize the flag to 2 and decrement on IRAP access unit so it
- // persists for the coded video sequence (e.g., between two IRAPs)
- s->present = 2;
-
- return 0;
-}
-
static int decode_nal_sei_content_light_info(HEVCSEIContentLight *s,
GetByteContext *gb)
{
@@ -206,8 +177,6 @@ static int decode_nal_sei_prefix(GetBitContext *gb, GetByteContext *gbyte,
return decode_nal_sei_decoded_picture_hash(&s->picture_hash, gbyte);
case SEI_TYPE_PIC_TIMING:
return decode_nal_sei_pic_timing(s, gb, ps, logctx);
- case SEI_TYPE_MASTERING_DISPLAY_COLOUR_VOLUME:
- return decode_nal_sei_mastering_display_info(&s->mastering_display, gbyte);
case SEI_TYPE_CONTENT_LIGHT_LEVEL_INFO:
return decode_nal_sei_content_light_info(&s->content_light, gbyte);
case SEI_TYPE_ACTIVE_PARAMETER_SETS:
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index 4189f5e6f7..077abdc74a 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -53,14 +53,6 @@ typedef struct HEVCSEIPictureTiming {
int picture_struct;
} HEVCSEIPictureTiming;
-typedef struct HEVCSEIMasteringDisplay {
- int present;
- uint16_t display_primaries[3][2];
- uint16_t white_point[2];
- uint32_t max_luminance;
- uint32_t min_luminance;
-} HEVCSEIMasteringDisplay;
-
typedef struct HEVCSEIContentLight {
int present;
uint16_t max_content_light_level;
@@ -96,7 +88,6 @@ typedef struct HEVCSEI {
H2645SEI common;
HEVCSEIPictureHash picture_hash;
HEVCSEIPictureTiming picture_timing;
- HEVCSEIMasteringDisplay mastering_display;
HEVCSEIContentLight content_light;
int active_seq_parameter_set_id;
HEVCSEITimeCode timecode;
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index fcf19b4eb6..434750965b 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -2763,53 +2763,9 @@ static int set_side_data(HEVCContext *s)
// Decrement the mastering display flag when IRAP frame has no_rasl_output_flag=1
// so the side data persists for the entire coded video sequence.
- if (s->sei.mastering_display.present > 0 &&
+ if (s->sei.common.mastering_display.present > 0 &&
IS_IRAP(s) && s->no_rasl_output_flag) {
- s->sei.mastering_display.present--;
- }
- if (s->sei.mastering_display.present) {
- // HEVC uses a g,b,r ordering, which we convert to a more natural r,g,b
- const int mapping[3] = {2, 0, 1};
- const int chroma_den = 50000;
- const int luma_den = 10000;
- int i;
- AVMasteringDisplayMetadata *metadata =
- av_mastering_display_metadata_create_side_data(out);
- if (!metadata)
- return AVERROR(ENOMEM);
-
- for (i = 0; i < 3; i++) {
- const int j = mapping[i];
- metadata->display_primaries[i][0].num = s->sei.mastering_display.display_primaries[j][0];
- metadata->display_primaries[i][0].den = chroma_den;
- metadata->display_primaries[i][1].num = s->sei.mastering_display.display_primaries[j][1];
- metadata->display_primaries[i][1].den = chroma_den;
- }
- metadata->white_point[0].num = s->sei.mastering_display.white_point[0];
- metadata->white_point[0].den = chroma_den;
- metadata->white_point[1].num = s->sei.mastering_display.white_point[1];
- metadata->white_point[1].den = chroma_den;
-
- metadata->max_luminance.num = s->sei.mastering_display.max_luminance;
- metadata->max_luminance.den = luma_den;
- metadata->min_luminance.num = s->sei.mastering_display.min_luminance;
- metadata->min_luminance.den = luma_den;
- metadata->has_luminance = 1;
- metadata->has_primaries = 1;
-
- av_log(s->avctx, AV_LOG_DEBUG, "Mastering Display Metadata:\n");
- av_log(s->avctx, AV_LOG_DEBUG,
- "r(%5.4f,%5.4f) g(%5.4f,%5.4f) b(%5.4f %5.4f) wp(%5.4f, %5.4f)\n",
- av_q2d(metadata->display_primaries[0][0]),
- av_q2d(metadata->display_primaries[0][1]),
- av_q2d(metadata->display_primaries[1][0]),
- av_q2d(metadata->display_primaries[1][1]),
- av_q2d(metadata->display_primaries[2][0]),
- av_q2d(metadata->display_primaries[2][1]),
- av_q2d(metadata->white_point[0]), av_q2d(metadata->white_point[1]));
- av_log(s->avctx, AV_LOG_DEBUG,
- "min_luminance=%f, max_luminance=%f\n",
- av_q2d(metadata->min_luminance), av_q2d(metadata->max_luminance));
+ s->sei.common.mastering_display.present--;
}
// Decrement the mastering display flag when IRAP frame has no_rasl_output_flag=1
// so the side data persists for the entire coded video sequence.
@@ -3667,7 +3623,7 @@ static int hevc_update_thread_context(AVCodecContext *dst,
s->sei.common.frame_packing = s0->sei.common.frame_packing;
s->sei.common.display_orientation = s0->sei.common.display_orientation;
s->sei.common.alternative_transfer = s0->sei.common.alternative_transfer;
- s->sei.mastering_display = s0->sei.mastering_display;
+ s->sei.common.mastering_display = s0->sei.common.mastering_display;
s->sei.content_light = s0->sei.content_light;
ret = export_stream_params_from_sei(s);
diff --git a/tests/ref/fate/hevc-hdr-vivid-metadata b/tests/ref/fate/hevc-hdr-vivid-metadata
index 5f69973098..cb5db4557f 100644
--- a/tests/ref/fate/hevc-hdr-vivid-metadata
+++ b/tests/ref/fate/hevc-hdr-vivid-metadata
@@ -1,5 +1,13 @@
[FRAME]
[SIDE_DATA]
+side_data_type=Content light level metadata
+max_content=0
+max_average=0
+[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=H.26[45] User Data Unregistered SEI message
+[/SIDE_DATA]
+[SIDE_DATA]
side_data_type=Mastering display metadata
red_x=34000/50000
red_y=16000/50000
@@ -13,14 +21,6 @@ min_luminance=50/10000
max_luminance=40000000/10000
[/SIDE_DATA]
[SIDE_DATA]
-side_data_type=Content light level metadata
-max_content=0
-max_average=0
-[/SIDE_DATA]
-[SIDE_DATA]
-side_data_type=H.26[45] User Data Unregistered SEI message
-[/SIDE_DATA]
-[SIDE_DATA]
side_data_type=HDR Dynamic Metadata CUVA 005.1 2021 (Vivid)
system_start_code=1
num_windows=1
diff --git a/tests/ref/fate/hevc-hdr10-plus-metadata b/tests/ref/fate/hevc-hdr10-plus-metadata
index f226cd8c7b..cdf308b96a 100644
--- a/tests/ref/fate/hevc-hdr10-plus-metadata
+++ b/tests/ref/fate/hevc-hdr10-plus-metadata
@@ -1,5 +1,10 @@
[FRAME]
[SIDE_DATA]
+side_data_type=Content light level metadata
+max_content=1000
+max_average=200
+[/SIDE_DATA]
+[SIDE_DATA]
side_data_type=Mastering display metadata
red_x=13250/50000
red_y=34500/50000
@@ -13,11 +18,6 @@ min_luminance=50/10000
max_luminance=10000000/10000
[/SIDE_DATA]
[SIDE_DATA]
-side_data_type=Content light level metadata
-max_content=1000
-max_average=200
-[/SIDE_DATA]
-[SIDE_DATA]
side_data_type=HDR Dynamic Metadata SMPTE2094-40 (HDR10+)
application version=1
num_windows=1
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH v2 2/3] avcodec: move content light level SEI handling to h2645_sei
2023-07-25 19:29 [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec: move mastering display colour volume " Jan Ekström
@ 2023-07-25 19:29 ` Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/hevcdec: simplify decrementing of MDCV/CLL flags Jan Ekström
2023-07-26 21:37 ` [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
3 siblings, 0 replies; 6+ messages in thread
From: Jan Ekström @ 2023-07-25 19:29 UTC (permalink / raw)
To: ffmpeg-devel
This allows this common H.274 SEI to be parsed from both H.264
as well as HEVC, as well as probably from VVC in the future.
Generally attempts to keep the original code as similar as possible.
FATE test refererence changes only change the order of side data
export within a single frame. Nothing else seems to have changed.
---
libavcodec/h2645_sei.c | 33 +++++++++++++++++++++++++
libavcodec/h2645_sei.h | 7 ++++++
libavcodec/h264_slice.c | 1 +
libavcodec/hevc_sei.c | 19 --------------
libavcodec/hevc_sei.h | 7 ------
libavcodec/hevcdec.c | 19 +++-----------
tests/ref/fate/hevc-hdr-vivid-metadata | 10 ++++----
tests/ref/fate/hevc-hdr10-plus-metadata | 10 ++++----
8 files changed, 54 insertions(+), 52 deletions(-)
diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c
index b1ec55d35b..cb6be0594b 100644
--- a/libavcodec/h2645_sei.c
+++ b/libavcodec/h2645_sei.c
@@ -422,6 +422,23 @@ static int decode_nal_sei_mastering_display_info(H2645SEIMasteringDisplay *s,
return 0;
}
+static int decode_nal_sei_content_light_info(H2645SEIContentLight *s,
+ GetByteContext *gb)
+{
+ if (bytestream2_get_bytes_left(gb) < 4)
+ return AVERROR_INVALIDDATA;
+
+ // Max and average light levels
+ s->max_content_light_level = bytestream2_get_be16u(gb);
+ s->max_pic_average_light_level = bytestream2_get_be16u(gb);
+ // As this SEI message comes before the first frame that references it,
+ // initialize the flag to 2 and decrement on IRAP access unit so it
+ // persists for the coded video sequence (e.g., between two IRAPs)
+ s->present = 2;
+
+ return 0;
+}
+
int ff_h2645_sei_message_decode(H2645SEI *h, enum SEIType type,
enum AVCodecID codec_id, GetBitContext *gb,
GetByteContext *gbyte, void *logctx)
@@ -445,6 +462,8 @@ int ff_h2645_sei_message_decode(H2645SEI *h, enum SEIType type,
case SEI_TYPE_MASTERING_DISPLAY_COLOUR_VOLUME:
return decode_nal_sei_mastering_display_info(&h->mastering_display,
gbyte);
+ case SEI_TYPE_CONTENT_LIGHT_LEVEL_INFO:
+ return decode_nal_sei_content_light_info(&h->content_light, gbyte);
default:
return FF_H2645_SEI_MESSAGE_UNHANDLED;
}
@@ -730,6 +749,19 @@ int ff_h2645_sei_to_frame(AVFrame *frame, H2645SEI *sei,
av_q2d(metadata->min_luminance), av_q2d(metadata->max_luminance));
}
+ if (sei->content_light.present) {
+ AVContentLightMetadata *metadata =
+ av_content_light_metadata_create_side_data(frame);
+ if (!metadata)
+ return AVERROR(ENOMEM);
+ metadata->MaxCLL = sei->content_light.max_content_light_level;
+ metadata->MaxFALL = sei->content_light.max_pic_average_light_level;
+
+ av_log(avctx, AV_LOG_DEBUG, "Content Light Level Metadata:\n");
+ av_log(avctx, AV_LOG_DEBUG, "MaxCLL=%d, MaxFALL=%d\n",
+ metadata->MaxCLL, metadata->MaxFALL);
+ }
+
return 0;
}
@@ -746,4 +778,5 @@ void ff_h2645_sei_reset(H2645SEI *s)
s->ambient_viewing_environment.present = 0;
s->mastering_display.present = 0;
+ s->content_light.present = 0;
}
diff --git a/libavcodec/h2645_sei.h b/libavcodec/h2645_sei.h
index 83e1b2ec16..0ebf48011a 100644
--- a/libavcodec/h2645_sei.h
+++ b/libavcodec/h2645_sei.h
@@ -113,6 +113,12 @@ typedef struct H2645SEIMasteringDisplay {
uint32_t min_luminance;
} H2645SEIMasteringDisplay;
+typedef struct H2645SEIContentLight {
+ int present;
+ uint16_t max_content_light_level;
+ uint16_t max_pic_average_light_level;
+} H2645SEIContentLight;
+
typedef struct H2645SEI {
H2645SEIA53Caption a53_caption;
H2645SEIAFD afd;
@@ -125,6 +131,7 @@ typedef struct H2645SEI {
H2645SEIFilmGrainCharacteristics film_grain_characteristics;
H2645SEIAmbientViewingEnvironment ambient_viewing_environment;
H2645SEIMasteringDisplay mastering_display;
+ H2645SEIContentLight content_light;
} H2645SEI;
enum {
diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c
index 586ce20bba..e576bcb070 100644
--- a/libavcodec/h264_slice.c
+++ b/libavcodec/h264_slice.c
@@ -440,6 +440,7 @@ int ff_h264_update_thread_context(AVCodecContext *dst,
h->sei.common.unregistered.x264_build = h1->sei.common.unregistered.x264_build;
h->sei.common.mastering_display = h1->sei.common.mastering_display;
+ h->sei.common.content_light = h1->sei.common.content_light;
if (!h->cur_pic_ptr)
return 0;
diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index b7b77d4d0c..351e699726 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -49,23 +49,6 @@ static int decode_nal_sei_decoded_picture_hash(HEVCSEIPictureHash *s,
return 0;
}
-static int decode_nal_sei_content_light_info(HEVCSEIContentLight *s,
- GetByteContext *gb)
-{
- if (bytestream2_get_bytes_left(gb) < 4)
- return AVERROR_INVALIDDATA;
-
- // Max and average light levels
- s->max_content_light_level = bytestream2_get_be16u(gb);
- s->max_pic_average_light_level = bytestream2_get_be16u(gb);
- // As this SEI message comes before the first frame that references it,
- // initialize the flag to 2 and decrement on IRAP access unit so it
- // persists for the coded video sequence (e.g., between two IRAPs)
- s->present = 2;
-
- return 0;
-}
-
static int decode_nal_sei_pic_timing(HEVCSEI *s, GetBitContext *gb,
const HEVCParamSets *ps, void *logctx)
{
@@ -177,8 +160,6 @@ static int decode_nal_sei_prefix(GetBitContext *gb, GetByteContext *gbyte,
return decode_nal_sei_decoded_picture_hash(&s->picture_hash, gbyte);
case SEI_TYPE_PIC_TIMING:
return decode_nal_sei_pic_timing(s, gb, ps, logctx);
- case SEI_TYPE_CONTENT_LIGHT_LEVEL_INFO:
- return decode_nal_sei_content_light_info(&s->content_light, gbyte);
case SEI_TYPE_ACTIVE_PARAMETER_SETS:
return decode_nal_sei_active_parameter_sets(s, gb, logctx);
case SEI_TYPE_TIME_CODE:
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index 077abdc74a..a23a64ec4f 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -53,12 +53,6 @@ typedef struct HEVCSEIPictureTiming {
int picture_struct;
} HEVCSEIPictureTiming;
-typedef struct HEVCSEIContentLight {
- int present;
- uint16_t max_content_light_level;
- uint16_t max_pic_average_light_level;
-} HEVCSEIContentLight;
-
typedef struct HEVCSEIAlternativeTransfer {
int present;
int preferred_transfer_characteristics;
@@ -88,7 +82,6 @@ typedef struct HEVCSEI {
H2645SEI common;
HEVCSEIPictureHash picture_hash;
HEVCSEIPictureTiming picture_timing;
- HEVCSEIContentLight content_light;
int active_seq_parameter_set_id;
HEVCSEITimeCode timecode;
} HEVCSEI;
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 434750965b..1fe91238d4 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -31,7 +31,6 @@
#include "libavutil/display.h"
#include "libavutil/film_grain_params.h"
#include "libavutil/internal.h"
-#include "libavutil/mastering_display_metadata.h"
#include "libavutil/md5.h"
#include "libavutil/opt.h"
#include "libavutil/pixdesc.h"
@@ -2769,21 +2768,9 @@ static int set_side_data(HEVCContext *s)
}
// Decrement the mastering display flag when IRAP frame has no_rasl_output_flag=1
// so the side data persists for the entire coded video sequence.
- if (s->sei.content_light.present > 0 &&
+ if (s->sei.common.content_light.present > 0 &&
IS_IRAP(s) && s->no_rasl_output_flag) {
- s->sei.content_light.present--;
- }
- if (s->sei.content_light.present) {
- AVContentLightMetadata *metadata =
- av_content_light_metadata_create_side_data(out);
- if (!metadata)
- return AVERROR(ENOMEM);
- metadata->MaxCLL = s->sei.content_light.max_content_light_level;
- metadata->MaxFALL = s->sei.content_light.max_pic_average_light_level;
-
- av_log(s->avctx, AV_LOG_DEBUG, "Content Light Level Metadata:\n");
- av_log(s->avctx, AV_LOG_DEBUG, "MaxCLL=%d, MaxFALL=%d\n",
- metadata->MaxCLL, metadata->MaxFALL);
+ s->sei.common.content_light.present--;
}
ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, NULL,
@@ -3624,7 +3611,7 @@ static int hevc_update_thread_context(AVCodecContext *dst,
s->sei.common.display_orientation = s0->sei.common.display_orientation;
s->sei.common.alternative_transfer = s0->sei.common.alternative_transfer;
s->sei.common.mastering_display = s0->sei.common.mastering_display;
- s->sei.content_light = s0->sei.content_light;
+ s->sei.common.content_light = s0->sei.common.content_light;
ret = export_stream_params_from_sei(s);
if (ret < 0)
diff --git a/tests/ref/fate/hevc-hdr-vivid-metadata b/tests/ref/fate/hevc-hdr-vivid-metadata
index cb5db4557f..f3c777a852 100644
--- a/tests/ref/fate/hevc-hdr-vivid-metadata
+++ b/tests/ref/fate/hevc-hdr-vivid-metadata
@@ -1,10 +1,5 @@
[FRAME]
[SIDE_DATA]
-side_data_type=Content light level metadata
-max_content=0
-max_average=0
-[/SIDE_DATA]
-[SIDE_DATA]
side_data_type=H.26[45] User Data Unregistered SEI message
[/SIDE_DATA]
[SIDE_DATA]
@@ -21,6 +16,11 @@ min_luminance=50/10000
max_luminance=40000000/10000
[/SIDE_DATA]
[SIDE_DATA]
+side_data_type=Content light level metadata
+max_content=0
+max_average=0
+[/SIDE_DATA]
+[SIDE_DATA]
side_data_type=HDR Dynamic Metadata CUVA 005.1 2021 (Vivid)
system_start_code=1
num_windows=1
diff --git a/tests/ref/fate/hevc-hdr10-plus-metadata b/tests/ref/fate/hevc-hdr10-plus-metadata
index cdf308b96a..f226cd8c7b 100644
--- a/tests/ref/fate/hevc-hdr10-plus-metadata
+++ b/tests/ref/fate/hevc-hdr10-plus-metadata
@@ -1,10 +1,5 @@
[FRAME]
[SIDE_DATA]
-side_data_type=Content light level metadata
-max_content=1000
-max_average=200
-[/SIDE_DATA]
-[SIDE_DATA]
side_data_type=Mastering display metadata
red_x=13250/50000
red_y=34500/50000
@@ -18,6 +13,11 @@ min_luminance=50/10000
max_luminance=10000000/10000
[/SIDE_DATA]
[SIDE_DATA]
+side_data_type=Content light level metadata
+max_content=1000
+max_average=200
+[/SIDE_DATA]
+[SIDE_DATA]
side_data_type=HDR Dynamic Metadata SMPTE2094-40 (HDR10+)
application version=1
num_windows=1
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH v2 3/3] avcodec/hevcdec: simplify decrementing of MDCV/CLL flags
2023-07-25 19:29 [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec: move mastering display colour volume " Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec: move content light level " Jan Ekström
@ 2023-07-25 19:29 ` Jan Ekström
2023-07-26 21:37 ` [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
3 siblings, 0 replies; 6+ messages in thread
From: Jan Ekström @ 2023-07-25 19:29 UTC (permalink / raw)
To: ffmpeg-devel
Mostly done to be able to update the comment so that it no longer
mentions the same flag twice.
---
libavcodec/hevcdec.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 1fe91238d4..15276edd33 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -2760,17 +2760,15 @@ static int set_side_data(HEVCContext *s)
AVFrame *out = s->ref->frame;
int ret;
- // Decrement the mastering display flag when IRAP frame has no_rasl_output_flag=1
- // so the side data persists for the entire coded video sequence.
- if (s->sei.common.mastering_display.present > 0 &&
- IS_IRAP(s) && s->no_rasl_output_flag) {
- s->sei.common.mastering_display.present--;
- }
- // Decrement the mastering display flag when IRAP frame has no_rasl_output_flag=1
- // so the side data persists for the entire coded video sequence.
- if (s->sei.common.content_light.present > 0 &&
- IS_IRAP(s) && s->no_rasl_output_flag) {
- s->sei.common.content_light.present--;
+ // Decrement the mastering display and content light level flag when IRAP
+ // frame has no_rasl_output_flag=1 so the side data persists for the entire
+ // coded video sequence.
+ if (IS_IRAP(s) && s->no_rasl_output_flag) {
+ if (s->sei.common.mastering_display.present > 0)
+ s->sei.common.mastering_display.present--;
+
+ if (s->sei.common.content_light.present > 0)
+ s->sei.common.content_light.present--;
}
ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, NULL,
--
2.41.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei
2023-07-25 19:29 [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
` (2 preceding siblings ...)
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/hevcdec: simplify decrementing of MDCV/CLL flags Jan Ekström
@ 2023-07-26 21:37 ` Jan Ekström
2023-07-27 19:22 ` Jan Ekström
3 siblings, 1 reply; 6+ messages in thread
From: Jan Ekström @ 2023-07-26 21:37 UTC (permalink / raw)
To: ffmpeg-devel
On Tue, Jul 25, 2023 at 10:29 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> This allows parsing code to be re-utilized from H.264, as well as probably
> from VVC in the future.
>
> This additionally eases verification of the AVCodecContext side data patch
> set, which includes libx264 integration for HDR10 side data.
>
> Changes from v1:
> * Reordered the new h2645_sei include to correct location as per alphabetical
> order. Thanks for Leo Izen for noticing this.
> * Cleaned up the mastering_display_metadata.h include in hevcdec, as that file
> no longer directly handles AVContentLightMetadata or
> AVMasteringDisplayMetadata.
>
> Notes:
> * In addition to testing with FATE, looking at the show_frames ffprobe output
> for a UHD BD sample with each IRAP containing these SEI entries, the
> behavior is the same as before with regards to each frame having the side
> data persist.
>
> There is also no change with tests I've done with a UHD BD mp4 remux as well
> as an iphone 12 sample I had around, So I think I have not modified the HEVC
> behavior in any great manner.
> * As for H.264, it now automatically gains support for these SEI messages. It
> seems like its definition of CVS (coded video sequence) is from one IDR to
> another (essentially a GOP). That said, currently the decoder resets the SEI
> setup in decode_nal_units, which means that the side data only persist for
> a single frame.
>
Unless there are objections, I will apply this tomorrow evening as
this is a strict improvement over the current situation where the
parsing is limited to HEVC and at least checking with ffprobe does not
show regressions for HEVC.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei
2023-07-26 21:37 ` [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
@ 2023-07-27 19:22 ` Jan Ekström
0 siblings, 0 replies; 6+ messages in thread
From: Jan Ekström @ 2023-07-27 19:22 UTC (permalink / raw)
To: ffmpeg-devel
On Thu, Jul 27, 2023 at 12:37 AM Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Tue, Jul 25, 2023 at 10:29 PM Jan Ekström <jeebjp@gmail.com> wrote:
> >
> > This allows parsing code to be re-utilized from H.264, as well as probably
> > from VVC in the future.
> >
> > This additionally eases verification of the AVCodecContext side data patch
> > set, which includes libx264 integration for HDR10 side data.
> >
> > Changes from v1:
> > * Reordered the new h2645_sei include to correct location as per alphabetical
> > order. Thanks for Leo Izen for noticing this.
> > * Cleaned up the mastering_display_metadata.h include in hevcdec, as that file
> > no longer directly handles AVContentLightMetadata or
> > AVMasteringDisplayMetadata.
> >
> > Notes:
> > * In addition to testing with FATE, looking at the show_frames ffprobe output
> > for a UHD BD sample with each IRAP containing these SEI entries, the
> > behavior is the same as before with regards to each frame having the side
> > data persist.
> >
> > There is also no change with tests I've done with a UHD BD mp4 remux as well
> > as an iphone 12 sample I had around, So I think I have not modified the HEVC
> > behavior in any great manner.
> > * As for H.264, it now automatically gains support for these SEI messages. It
> > seems like its definition of CVS (coded video sequence) is from one IDR to
> > another (essentially a GOP). That said, currently the decoder resets the SEI
> > setup in decode_nal_units, which means that the side data only persist for
> > a single frame.
> >
>
> Unless there are objections, I will apply this tomorrow evening as
> this is a strict improvement over the current situation where the
> parsing is limited to HEVC and at least checking with ffprobe does not
> show regressions for HEVC.
>
Applied the set as 33358b862c8b796362218f12555e351aaf35a8f4 ,
43e63ff20a51e0296c446a9deec613df6fd52cb8 and
91e1d11d1405f325f6f52e2c8dd5bbbf2462e190.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-27 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-25 19:29 [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 1/3] avcodec: move mastering display colour volume " Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec: move content light level " Jan Ekström
2023-07-25 19:29 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/hevcdec: simplify decrementing of MDCV/CLL flags Jan Ekström
2023-07-26 21:37 ` [FFmpeg-devel] [PATCH v2 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei Jan Ekström
2023-07-27 19:22 ` Jan Ekström
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git