From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6DF1746F61 for ; Sun, 23 Jul 2023 18:09:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8002068C6F7; Sun, 23 Jul 2023 21:09:03 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 85FC068C199 for ; Sun, 23 Jul 2023 21:08:57 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EBCC31C0002 for ; Sun, 23 Jul 2023 18:08:56 +0000 (UTC) Date: Sun, 23 Jul 2023 20:08:56 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230723180856.GL7802@pb2> References: <20230723180303.8000-1-michael@niedermayer.cc> <20230723180303.8000-5-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/h266_metadata_bsf: Check if there are CodedBitstreamFragment units X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============9025587546105946889==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============9025587546105946889== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUBKWyapWpFAak7q" Content-Disposition: inline --UUBKWyapWpFAak7q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 23, 2023 at 03:07:32PM -0300, James Almer wrote: > On 7/23/2023 3:03 PM, Michael Niedermayer wrote: > > Fixes: NULL pointer dereference > > Fixes: 60269/clusterfuzz-testcase-minimized-ffmpeg_BSF_VVC_METADATA_fuz= zer-5215449416335360 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/h266_metadata_bsf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavcodec/h266_metadata_bsf.c b/libavcodec/h266_metadata_= bsf.c > > index c0dbf8ef96..1f0f875cfe 100644 > > --- a/libavcodec/h266_metadata_bsf.c > > +++ b/libavcodec/h266_metadata_bsf.c > > @@ -43,7 +43,7 @@ static int h266_metadata_update_fragment(AVBSFContext= *bsf, AVPacket *pkt, > > int err, i; > > // If an AUD is present, it must be the first NAL unit. > > - if (pu->units[0].type =3D=3D VVC_AUD_NUT) { > > + if (pu->nb_units && pu->units[0].type =3D=3D VVC_AUD_NUT) { > > if (ctx->aud =3D=3D BSF_ELEMENT_REMOVE) > > ff_cbs_delete_unit(pu, 0); > > } else if ( pkt && ctx->aud =3D=3D BSF_ELEMENT_INSERT) { >=20 > Should be ok. will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --UUBKWyapWpFAak7q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZL1suAAKCRBhHseHBAsP qx2wAJ9+5q0FBZQ9X8UrbZa2i8O6aMlpLQCfYy+Gm3WyPUY+gjMTW+D7/IxIMX0= =LytQ -----END PGP SIGNATURE----- --UUBKWyapWpFAak7q-- --===============9025587546105946889== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============9025587546105946889==--